PR#636: buildinstall: Use boot as disc type - pungi

pungi

#636 buildinstall: Use boot as disc type

Closed 6 years ago by lsedlar. Opened 6 years ago by lsedlar.

lsedlar/pungi buildinstall-volume-id into master

No commits found

This will be reflected in the volume id of boot.iso created by Lorax. The actual value can be changed in the configuration (for Fedora there already is a mapping from boot to netinst).

Relates: https://pagure.io/releng/issue/6173

I'm not sure whether or not this would break something, particularly whether the createiso phase created image will remain functional after changing the volume id (no idea if boot configuration refers to the id or is updated in the process).

ausil commented 6 years ago

Could we get a test done in stage before merging this? I would like to be sure that the boot configs come out sane. I know it won't work at all for running the pungi command as it builds the boot iso and DVD in the same run and uses the same configs into it's input. I've always leaned to closing the releng issue as won't fix. Just because I have felt it would involve some massive rewriting to change the logic

lsedlar commented 6 years ago

Yup, that would be nice. I filed fedora-infrastructure#6100 to get prod sync to stage to actually be able to run the compose.

ausil commented 6 years ago

@lsedler there was a prod sync last week to stg

rebased

6 years ago

lsedlar commented 6 years ago

The ISO created in creatiso phase does not boot (Not all disks can be found).

None of the live media tasks in the compose succeeded. This could be caused by something else that this patch though, so I'm trying them again with same package set but with original volume id.

lsedlar commented 6 years ago

The live media failed the same way even without this patch, so I can't test if they boot or not.

I'll close this PR anyway, as in its current way it's still breaking some ISOs. I'll check how difficult it would be to tweak the boot config.

Pull-Request has been closed by lsedlar

6 years ago