PR#394: Also send the num with the ostree compose fedmsg - pungi

pungi

#394 Also send the num with the ostree compose fedmsg

Closed 7 years ago by puiterwijk. Opened 7 years ago by puiterwijk.

puiterwijk/pungi ostree-fedmsg into master

Also send the num with the ostree compose fedmsg

Patrick Uiterwijk • 7 years ago

fa726ce

pungi/phases/ostree.py

file modified

		`@@ -61,6 +61,7 @@`
		`compose.notifier.send('ostree',`
		`variant=variant.uid,`
		`arch=arch,`
		`+ num=self.num,`
		`ref=ref,`
		`commitid=commitid)`

tests/test_ostree_phase.py

file modified

		`@@ -174,6 +174,7 @@`
		`[mock.call('ostree',`
		`variant='Everything',`
		`arch='x86_64',`
		`+ num=1,`
		`ref='fedora-atomic/25/x86_64',`
		`commitid='fca3465861a')])`

		`@@ -194,6 +195,7 @@`
		`[mock.call('ostree',`
		`variant='Everything',`
		`arch='x86_64',`
		`+ num=1,`
		`ref=None,`
		`commitid=None)])`

puiterwijk commented 7 years ago

Signed-off-by: Patrick Uiterwijk puiterwijk@redhat.com

puiterwijk commented 7 years ago

This makes sure we send all information needed to calculate the workdir on the receiving end.

lsedlar commented 7 years ago

The number is there only so that we can make sure the paths are unique. If your consumer needs the path, why not send directly the path?

lsedlar commented 7 years ago

More specifically, which path are you interested in? So far, there have been no guarantees about filesystem structures other than the compose/ subdirectory. I'm not saying it's not possible, but if someone depends on other bits, it should be mentioned somewhere so that the path does not change in a couple months.

puiterwijk commented 7 years ago

Right. My goal here is to be able to find the produced tree repository on the nfs file system.
Any chance you can point me to where that would be, as it doesn't seem to actually be under the compose/ directory...

lsedlar commented 7 years ago

Ah, that path. In the run() method you can access the path in compose["ostree_repo"] (example). It's not in the compose dir, because that would create a new repo for each compose, not add commits to an existing one. As far as I know @ausil has some plans to change that at some point, but I don't have any specifics.

The path is coming from the settings file (e.g. in rawhide), Pungi does not really do anything else with it other than pass it to rpm-ostree.

Edited 7 years ago by lsedlar

puiterwijk commented 7 years ago

Ahhh! Perfect, thanks! Then we can close this PR out.

Pull-Request has been closed by puiterwijk

7 years ago