pungi

Clone

#1723 Fix buildinstall reuse with pungi_buildinstall plugin
Merged 3 months ago by lsedlar. Opened 3 months ago by lsedlar.
lsedlar/pungi buildinstall-reuse-fix  into  master

file modified
+2 -2 
@@ -709,8 +709,8 @@ 
 

          # input on RPM level.
 

          cmd_copy = copy(cmd)
 

          for key in ["outputdir", "sources"]:
 

-             del cmd_copy[key]
 

-             del old_metadata["cmd"][key]
 

+             cmd_copy.pop(key, None)
 

+             old_metadata["cmd"].pop(key, None)
 

  

          # Do not reuse if command line arguments are not the same.
 

          if old_metadata["cmd"] != cmd_copy:

The keys may not exist anymore. If there's nothing to delete, it's fine.

rebased onto 52c2cea
3 months ago

Looks good to me. :thumbsup:

Pull-Request has been merged by lsedlar
3 months ago
Metadata
None
No Tags
Changes Summary 1
+2 -2
file changed
pungi/phases/buildinstall.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.