PR#1714: checks: don't require "repo" in the "ostree" schema - pungi

pungi

#1714 checks: don't require "repo" in the "ostree" schema

Merged a year ago by lsedlar. Opened a year ago by adamwill.

adamwill/pungi ostree-dont-require-repo into master

checks: don't require "repo" in the "ostree" schema

Adam Williamson • a year ago

4210300

pungi/checks.py

file modified

-1

		`@@ -1066,7 +1066,6 @@`
		`"required": [`
		`"treefile",`
		`"config_url",`
		`- "repo",`
		`"ostree_repo",`
		`],`
		`"additionalProperties": False,`

adamwill commented a year ago

Per @siosm in https://pagure.io/pungi-fedora/pull-request/1227
this option "is deprecated and not needed anymore", so Pungi
should not be requiring it.

Signed-off-by: Adam Williamson awilliam@redhat.com

lsedlar commented a year ago

Thanks!

The option is valid, but it only makes sense for external repos. The ostree phase runs before the variant repos are generated, so setting Everything doesn't actually do anything useful.

Before merging, I'll also adjust accessing the option to make sure that will not require it: #1715.

lsedlar commented a year ago

Commit 432b0bc fixes this pull-request