PR#1446: pkgset: Handle exceptions in pkgset threads - pungi

pungi

#1446 pkgset: Handle exceptions in pkgset threads

Merged 3 years ago by lsedlar. Opened 3 years ago by lsedlar.

lsedlar/pungi pkgset-handle-exception into master

pkgset: Handle exceptions in pkgset threads

Lubomír Sedlář • 3 years ago

22efe15

pungi/phases/pkgset/common.py

file modified

+7 -2

		`@@ -271,8 +271,13 @@`

		`small_pool.start()`
		`big_pool.start()`
		`- small_pool.stop()`
		`- big_pool.stop()`
		`+ try:`
		`+ small_pool.stop()`
		`+ except Exception:`
		`+ big_pool.kill()`
onosek commented 3 years ago If kill() doesn't require some after-cleanup, I am OK with it.
		`+ raise`
		`+ finally:`
		`+ big_pool.stop()`

		`return small_pool.results + big_pool.results`

lsedlar commented 3 years ago

There are two thread pools for making package sets. If Pungi is being terminated by external event and the exception is handled in the first thread, the second one never gets to the stop method and the process keeps hanging.

This patch should make sure that stop() is called on both pools.