#1296 tests: Add test for compose logger setup
Merged 4 years ago by lsedlar. Opened 4 years ago by hlin.
hlin/pungi master  into  master

file modified
+25
@@ -1,5 +1,6 @@ 

  # -*- coding: utf-8 -*-

  

+ import logging

  import mock

  try:

      import unittest2 as unittest
@@ -30,6 +31,30 @@ 

          shutil.rmtree(self.tmp_dir)

  

      @mock.patch('pungi.compose.ComposeInfo')

+     def test_setup_logger(self, ci):

+         conf = {}

+         logger = logging.getLogger('test_setup_logger')

+         compose = Compose(conf, self.tmp_dir, logger=logger)

+         self.assertEqual(len(logger.handlers), 2)

+ 

+         pungi_log = logger.handlers[0].stream.name

+         exclude_arch_log = logger.handlers[1].stream.name

+         self.assertEqual(os.path.basename(pungi_log), 'pungi.global.log')

+         self.assertEqual(os.path.basename(exclude_arch_log), 'excluding-arch.global.log')

+ 

+         msg = "test log"

+         compose.log_info(msg)

+         with open(pungi_log) as f:

+             self.assertTrue(msg in f.read())

+         with open(exclude_arch_log) as f:

+             self.assertTrue(msg not in f.read())

+ 

+         msg = "Populating package set for arch: x86_64"

+         compose.log_info(msg)

+         with open(exclude_arch_log) as f:

+             self.assertTrue(msg in f.read())

+ 

+     @mock.patch('pungi.compose.ComposeInfo')

      def test_can_fail(self, ci):

          conf = {

              'failable_deliverables': [

PR#1267 brings in some uncovered code which introduced
an issue fixed by PR#1292.

Signed-off-by: Haibo Lin hlin@redhat.com

Looks good to me. :thumbsup:

Pull-Request has been merged by lsedlar

4 years ago