#975 Deprecate runroot option
Closed: Fixed 5 years ago by lsedlar. Opened 6 years ago by lsedlar.

The runroot option is currently required. However it does not seem useful. If runroot is enabled, the user has to specify runroot_tag. Pungi could just use that one option. If we have a tag to run in, use runroot, otherwise run things locally.

For backwards compatibility the option should be accepted for a few more releases, but emit a warning that it's no longer required.


Metadata Update from @lsedlar:
- Issue assigned to andilinux

6 years ago

For backwards compatibility the option should be accepted for a few more releases, but emit a warning that it's no longer required.

PR https://pagure.io/pungi/pull-request/1224
Both 'alias' and 'append' could emit a warning, but seems them not matching this case.

After fixing this issue, I'm thinking making 'runroot_method' option mandatory with 'local' as default value and extra options are required according to different value of it, e.g. when runroot_method = 'openssh', runroot_ssh_* options should be set. I'm not sure if I understand it correctly. @lsedlar what's your opinion?

Metadata Update from @lsedlar:
- Issue set to the milestone: 4.1.38

5 years ago

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #1224 Merged 5 years ago