Learn more about these different git repos.
Other Git URLs
I have a pungi config that explicitly marks "buildinstall" as a skipped step, but the ostree_installer configuration still fails to verify because the ostree_installer and buildinstall phases would conflict. Maybe it's an idea to change the check in pungi/phases/ostree_installer.py to if conf and not variant.is_empty and 'buildinstall' not in self.compose.skip_phases, or would that still conflict with another phase?
pungi/phases/ostree_installer.py
if conf and not variant.is_empty and 'buildinstall' not in self.compose.skip_phases
The compose that errored: https://kojipkgs.fedoraproject.org/compose/updates/Fedora-28-updates-testing-20180414.0/logs/global/pungi.global.log
"skip_phases": [ "buildinstall", "productimg", "extra_files" ],
Me too. I have discovered the same class of issue with my compose. The expectation is ostree_installer replaces the normal buildinstall, and it's my opinion that it's acceptable for ostree_installer to clobber or overlay any existing things within the scope of the variant. At least that is the situation in my use-case. For now I'm trying to work around this with an side variant for ostree_installer.
We could turn the error into a warning. That should solve the problem that @parasense is having, but such warning is really easy to miss and it it would basically bring #695 back.
Commit 543154d fixes this issue
Commit 7c237c2 relates to this ticket
It looks like 543154d doesn't quite work. The _skipped property of the buildinstall phase doesn't seem to be set quite right, see: https://kojipkgs.fedoraproject.org/compose/iot/Fedora-IoT-28-20180524.2/logs/global/.
_skipped
The ostree_installer_overwrite option seems to work (at least allows the compose to start), so I'm using that as a workaround for now.
ostree_installer_overwrite
Metadata Update from @puiterwijk: - Issue status updated to: Open (was: Closed)
Ah, I see why: ._skipped is only set by start(): https://pagure.io/pungi/blob/master/f/pungi/phases/base.py#_57
._skipped
start()
We should probably change the check in the ostree_installer phase to use self.bi.skip().
self.bi.skip()
That will fix it, but in case buildinstall phase is not running because the product is not bootable there will be duplicated log message. Not a big deal I guess.
Commit 288d9ec fixes this issue
Login to comment on this ticket.