#903 Adjust to introduction of anaconda-install-env-deps package
Closed: Invalid 5 years ago Opened 6 years ago by adamwill.

A recent anaconda change changed the package setup such that several things which were previously required by anaconda-core are now required instead by a new subpackage, anaconda-install-env-deps. The intent (AIUI) is to allow "things like initial-setup" (which so far seems to mean, basically, initial-setup...) to get the bits of anaconda they actually need to function, without all the things needed only to actually install an operating system.

Corresponding changes were made to fedora-kickstarts and lorax to make them pull in this new subpackage when appropriate, but there are two places in Pungi which I think may also need changing, these two:

I believe both of those are expecting to get the full set of deps when they install anaconda, but as this change currently stands, they won't (the anaconda package does not depend on anaconda-install-env-deps at present).

See also https://github.com/rhinstaller/anaconda/pull/1415#issuecomment-380565916 and https://github.com/rhinstaller/anaconda/pull/1415#issuecomment-380567059 for some thoughts I had on this.


I'm not sure what exactly pungi needs, but please note that both places pointed out are relevanant only when the old buildinstall script is used instead of lorax. This is that case only for RHEL 6 as far as I know.

I wonder if those parts in pagure are usable without those dependencies or they are really required. I guess they are needed but it would be nice to check this actually because if that works it is even better for pagure. Based on the comment above it looks like the first part (buildinstall) doesn't require those because this metapackage won't go to RHEL-6 at all.

About solution, maybe (I guess it is) it is nonsense to do it now after all the pieces already moved. However, what about having two anaconda meta packages. One which will be used in all the places where you need all the dependencies and second for initial-setup and places where you don't want those. That would leave Anaconda as it was before and it could be changed only on places where it matters.

@lsedlar if neither of these are used when lorax is used, this probably isn't a problem. I'm just trying to find potential issues before we run into them.

@jkonecny I suggested something along those lines in the original PR. I don't think we actually need two metapackages, we could just have the existing anaconda metapackage depend on the install-env-deps subpackage; things that don't want to pull it in could still require anaconda-gui or anaconda-tui directly...

@adamwill there's more then just anaconda-gui and anaconda-tui and also it will most probably change thanks to Anaconda modularization.

Adding @pbrobinson as the ARM image size is one of the main drivers of the anaconda-install-env-deps change.

I've looked on more details on how the "anaconda", "anaconda-core", "anaconda-tui" and "anaconda-gui" packages interact and are used. It seems to be safe to make the "anaconda" package depend on "anaconda-install-env-deps".

That way any expectations that the "anaconda" package pulls in everything will still hold.

Initial Setup depends on "anaconda-tui" and/or "anaconda-gui", which pull in "anaconda-core" - there is no direct dependency on the "anaconda" package, so the new dependency should not cause issues.

Anaconda PR: https://github.com/rhinstaller/anaconda/pull/1432

BTW, the Anaconda test day is actually on Monday, not Tuesday: https://fedoraproject.org/wiki/Test_Day:2017-04-06_AnacondaBlivetGUI

So it would be really good to get that fix to this to composes as soon as possible, due to all the delays that happen with our current pipeline so it can be actually tested during the testday.

That seems reasonable to me - it's at least a safer starting point, if it turns out there is a reason it would be beneficial to break the dep from anaconda to anaconda-install-env-deps, it can be done at a later time and possibly only on Rawhide.

I'm going to close this is issue as current version of Pungi does not directly depend on anaconda; it's always used by another tool such as lorax. If there is a problem, it would have to be fixed there.

Thanks for raising this issue!

Metadata Update from @lsedlar:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata