#868 Compose metadata has seven entries for the same source DVD
Closed: Invalid 5 years ago Opened 6 years ago by adamwill.

The Fedora compose recently has been generating a source DVD ISO image for the Modular variant (it shouldn't be, but it is):

https://kojipkgs.fedoraproject.org/compose/branched/Fedora-28-20180312.n.0/compose/Modular/source/iso/

This has a rather funny effect on the images.json metadata - it has seven entries (one per arch) for the same file! Here's a shortened extract:

        "Modular": {
            "aarch64": [
                {
                    "arch": "src",
                    "bootable": false,
                    "checksums": {
                        "sha256": "9e3edf6778a66d4ad967647982ead5e2630514b13a2ca15d638c7e2eb6b9e856"
                    },
                    "disc_count": 1,
                    "disc_number": 1,
                    "format": "iso",
                    "implant_md5": "a47963ff5abe4a34cd04180d44e450a4",
                    "mtime": 1520866523,
                    "path": "Modular/source/iso/Fedora-Modular-dvd-source-28-20180312.n.0.iso",
                    "size": 97245184,
                    "subvariant": "Modular",
                    "type": "dvd",
                    "volume_id": "Fedora-Modular-dvd-src-28"
                }
            ],
            "armhfp": [
                {
                    "arch": "src",
                    "bootable": false,
                    "checksums": {
                        "sha256": "9e3edf6778a66d4ad967647982ead5e2630514b13a2ca15d638c7e2eb6b9e856"
                    },
                    "disc_count": 1,
                    "disc_number": 1,
                    "format": "iso",
                    "implant_md5": "a47963ff5abe4a34cd04180d44e450a4",
                    "mtime": 1520866523,
                    "path": "Modular/source/iso/Fedora-Modular-dvd-source-28-20180312.n.0.iso",
                    "size": 97245184,
                    "subvariant": "Modular",
                    "type": "dvd",
                    "volume_id": "Fedora-Modular-dvd-src-28"
                }
            ],
            "i386": [
                {
                    "arch": "src",
                    "bootable": false,
                    "checksums": {
                        "sha256": "9e3edf6778a66d4ad967647982ead5e2630514b13a2ca15d638c7e2eb6b9e856"
                    },
                    "disc_count": 1,
                    "disc_number": 1,
                    "format": "iso",
                    "implant_md5": "a47963ff5abe4a34cd04180d44e450a4",
                    "mtime": 1520866523,
                    "path": "Modular/source/iso/Fedora-Modular-dvd-source-28-20180312.n.0.iso",
                    "size": 97245184,
                    "subvariant": "Modular",
                    "type": "dvd",
                    "volume_id": "Fedora-Modular-dvd-src-28"
                }
            ],

This clearly seems wrong.


Why is it clearly wrong? When you want images relevant for Modular.i386, the source image is clearly relevant to that. It just happens to be the same for all architectures.

Hmmm - when you put it that way, you have a point. I guess I've been assuming that images.json should be a one-to-one representation of images that exist within the compose, but I suppose that's actually an assumption on my part :/

(Of course, if it's OK for the same image to appear in it more than once, that makes the job of something like fedfind - which just wants to find out and organize all the images in the compose - rather harder, so that'll be fun...)

While I see the value for fedfind in changing this, I'm not convinced it would outweigh having to make sure all consumers work with the changed layout. while I know of a few Red Hat internal scripts that consume the metadata, anything else could be reading it from PDC.

I'm going to close this issue. If you disagree, feel free to reopen.

Metadata Update from @lsedlar:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

5 years ago

That's fine, no objection.

Login to comment on this ticket.

Metadata