#809 move to pykickstart-3
Opened 4 years ago by clumens. Modified 3 years ago

Over the past two years, I've been working on a new version of pykickstart that cleans up a bunch of stuff and corrects some inherent flaws, as well as stops using certain deprecated python modules. The result is that there are some incompatibilities between v2 and v3. The projects that are most affected are the ones that really dig in and do a lot of custom stuff. It's been in the works a long time now and with anaconda starting to adapt, I feel like it's probably time to get rid of pykickstart-2 and use pykickstart-3 in Fedora.

There is a copr with the new version here: https://copr.fedorainfracloud.org/coprs/clumens/pykickstart-3/, and there's a document describing the changes here: https://github.com/rhinstaller/pykickstart/blob/master/docs/2to3.

I've taken a brief look through pungi and I don't see that you are doing much of the custom stuff that will require real change. There might be a use of KickstartValueError floating around, though. I would be happy to help work on whatever patches are required, if you can suggest a way for me to test pungi against the copr repo.

I took another pass through the code and still didn't see anything that looks like it needs to be changed. Most of the kickstart-related code is packages and repos, and I don't think anything's changed there. I took a pass through my 2to3 document and grepped the pungi source, and nothing on that list is being used. So I think we're good. I just want to test to double check.

All unit tests are passing with pykickstart-3.7. I also started a test compose on stage server with the package from COPR. I'll report some results once it finishes.

The testing compose finished successfully and there are no differences to what is created with older version of pykickstart. I think we're good.

Great, thanks for checking! I am in Brno this week so I am going to try to coordinate with the Anaconda guys and a couple others to get all the patches pushed in the same time frame.

Login to comment on this ticket.