#752 remove remaining hard coded createrepo threads
Closed: Fixed 6 years ago Opened 6 years ago by kevin.

In https://pagure.io/pungi/c/dec00fe2f4e987573323126b49f26bf83a4a46c8?branch=master the number of threads for createrepo was made configurable with a default of number of cpus.

There's 3 more places where this value is hard coded:

pungi/phases/createiso.py:            cmd = repo.get_createrepo_cmd(tree_dir, update=True, database=True, skip_stat=True, pkglist=file_list, outputdir=iso_dir, workers=3, checksum=createrepo_checksum)
pungi/phases/createrepo.py:                                  pkglist=file_list, outputdir=repo_dir, workers=3,
pungi/phases/pkgset/common.py:    cmd = repo.get_createrepo_cmd(path_prefix, update=True, database=True, skip_stat=False, pkglist=compose.paths.work.package_list(arch="global"), outputdir=repo_dir_global, baseurl="file://%s" % path_prefix, workers=5, update_md_path=update_md_path, checksum=createrepo_checksum)
pungi/phases/pkgset/common.py:    cmd = repo.get_createrepo_cmd(path_prefix, update=True, database=True, skip_stat=True, pkglist=compose.paths.work.package_list(arch=arch), outputdir=repo_dir, baseurl="file://%s" % path_prefix, workers=5, groupfile=comps_path, update_md_path=repo_dir_global, checksum=createrepo_checksum)

Can we get those workers using the same configurable value instead of hard coded 3 or 5?


The option added in the linked commit does not change worker threads in createrepo, but the number of createrepo processes as a whole. I admit the name is not great. I guess this should be a separate option.

Ah, yeah... it would be good to have them configurable also, or at least the vaules set based on something rather than magic numbers. ;)

Metadata Update from @lsedlar:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Metadata Update from @lsedlar:
- Issue tagged with: 4.1.20

6 years ago

Login to comment on this ticket.

Metadata