#678 ostree configuration is too verbose
Closed: Fixed 6 years ago Opened 6 years ago by lsedlar.

Right now the ostree block is mapping variants and arches has to duplicate the same config for each architecture, despite the config being identical.

https://pagure.io/pungi-fedora/blob/22fc96e0b0a3c5a005ed34844d401d54c0027693/f/fedora.conf#_709-749

The Atomic variant has the same config three times, once for each architecture. But the config for different arches in the same repo should most likely be the same.

Instead it should look like this:

ostree = {
    "^Atomic$": {
        "version": '!OSTREE_VERSION_FROM_LABEL_DATE_TYPE_RESPIN',
        "treefile": "fedora-atomic-host.json",
        "config_url": "https://pagure.io/fedora-atomic.git",
        "config_branch": "master",
        "repo": "Everything",
        "ostree_repo": "/mnt/koji/compose/atomic/rawhide/",
        "arches": ["aarch64", "ppc64le", "x86_64"],
        "failable": ["*"],
    }
}

Right now we allow only one ostree per variant.arch combination, so it probably makes sense to limit to one ostree per variant generally.

CC @dustymabe for feedback


Honestly I'm not sure. Once we implement the change in https://pagure.io/pungi/pull-request/697 would we still be able to have separate config sections if we need to for some reason?

I'm +1 for deduplicating configuration, but I want to make sure we don't artificially limit ourselves at the same time.

PR updated to allow multiple config blocks in a single variant.

Sure. The arch differences are maintained in the treefile today.

Metadata Update from @lsedlar:
- Issue assigned to lsedlar
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

6 years ago

Metadata Update from @lsedlar:
- Issue tagged with: 4.1.18

6 years ago

Login to comment on this ticket.

Metadata