Learn more about these different git repos.
Other Git URLs
When I do a compose with pkgset_source = "koji", Pungi runs repoclosure at the very end, using gather_lookaside_repos. What do you think about making the compose fail if repoclosure fails? This would bubble up errors to QE sooner. (And it would match how RH's internal Puddle tool works.)
pkgset_source = "koji"
gather_lookaside_repos
See #683 for a related request.
The first part about making repoclosure actually do something is a very reasonable request. I'm not sure if it should be triggered by the existing check_deps (which aborts compose when depsolving fails) option or a new option should be introduced. Would someone want to allow failures in depsolving but require repoclosure to pass? Is that even possible?
check_deps
Aborting when comps file mentions a non-existing package is something else. I'll split the request into a separate issue.
There is at least one case where check_deps would be fine in depsolving, but repoclosure fails. When a package from integrated layered product has a dependency on something that is included in an addon, that package will be trimmed from the integrated layered product causing repoclosure to fail. This however seems like a bug in how repoclosure is called, as it should probably include the addon as well.
PR #689 adds allows you to configure the compose to fail if repoclosure fails. I decided against reusing the existing option as the new option allows changing the setting per variant.
Metadata Update from @lsedlar: - Issue close_status updated to: Fixed - Issue status updated to: Closed (was: Open)
Metadata Update from @lsedlar: - Issue tagged with: 4.1.18
Login to comment on this ticket.