#598 Fail to validate live_images configuration
Closed: Fixed 7 years ago Opened 7 years ago by lsedlar.

Since #581 this not longer validates as correct. It should work for backwards compatibility. Instead it says the config is not valid for any schema.

live_images = [
    ('^Spins$', {
         'armhfp': {
             'kickstart': 'fedora-arm-kde.ks',
             'repo_from': 'Everything',
    }}),
]

Renaming the repo_from key to repo fixes this.

@qwan, any idea what could be wrong?


Sorry, this is a regression introduced in the unify repo option patch, jsonschema's anyOf validator yield ValidationError when our customized ConfigOptinoWarning is found.

One simple solution is just removing all of the ConfigOptinoWarning in the hook wrapper, this is simple and pretty safe, however the old option will be updated (like repo_from -> repo) silently.

Another solution is overwrite jsonschema's anyOf validator, I have a patch #599 with this solution for review.

Before a fix is available in new build, user can update their config files to use option name repo to replace old option names like repo_from, source_repo_from, additionoal_repos to workaround this issue.

Commit 63327e7 fixes this issue

Metadata Update from @lsedlar:
- Issue assigned to qwan
- Issue tagged with: 4.1.15

6 years ago

Login to comment on this ticket.

Metadata