#48 pungi-koji slimming down executable
Closed: Invalid 5 years ago Opened 8 years ago by lkocman.

Hello,

debugging pungi can be a bit of pain. I usually end up by commenting pieces of code to be actually able to skip "un-skippable" which might fail in case that you're re-spinning just single phase and e.g. skipped. Writing treeinfo would fail for sure.

My advice here is to simply put phase dependent code from pungi-koji into end of given phase.

The result would be that pungi-koji only processes arguments and launches phases and marks compose as finished. No additional code is expected.

Also checksums could have separate "post" phase.
I'd keep latest-symlink in the code but, create option to skip it with default=False to not change behavior.

This would help with debugging individual phases in a way that you wouldn't have to touch binary at all.

Lubos


  • Checksums are already computed in separate phase.
  • latest symlink can be disabled

So the remaining part is writing .treeinfo, .discinfo and media.repo files. It would probably have to go into a new separate phase (MediaMetadata maybe?) that would be scheduled before createiso and after both buildinstall and productimg.

Another non-phase work in main script is writing composeinfo.json, images.json and osbs.json. That last one should move directly to osbs phase.

I'm going to close this issue as it's not something we plan to do any time soon. It would be great to refactor this part of the code base, but the requirements today are slightly different to what they were two years ago.

Metadata Update from @lsedlar:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

5 years ago

Login to comment on this ticket.

Metadata