#418 'dvd' in ostree installer filenames is not the best choice
Closed: Fixed 7 years ago Opened 7 years ago by adamwill.

In phases/ostree_installer.py, Pungi defaults to setting disc_type to 'dvd' when calling compose.get_image_name(), which means Atomic installer images wind up with filenames like Fedora-Workstation-dvd-x86_64-25_Beta-1.1.iso and Fedora-Atomic-dvd-x86_64-Rawhide-20161005.n.0.iso.

This is kinda bad, because we're quite used to 'dvd' in a filename meaning it's a traditional old-school 'installer DVD', i.e. one with a bunch of RPMs on it that lets you choose (to some degree) which ones to install. Since Fedora now has a Workstation ostree installer image, we have a Fedora-Workstation-dvd-(arch)-(release).iso and a Fedora-Server-dvd-(arch)-(release).iso, which looks a lot like they should be basically the same thing only one for Server and one for Workstation, but they aren't: the Workstation one is an ostree installer image, while the Server one is a traditional install DVD.

@ausil and I both think we should use a different token in this case, perhaps just 'ostree'.

See also https://pagure.io/pungi/issue/417 , which is kinda related / similar, but for productmd metadata values rather than the filename.


PR #420 changes the default value to ostree with option to change it via config file.

The patch is merged and it will go out in next release.

@lsedlar changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata