#363 Image missing from metadata
Closed: Fixed 7 years ago Opened 7 years ago by adamwill.

In the last successful Fedora 25 compose, Fedora-25-20160810.n.0 , the ARM minimal raw.xz disk image composed and is present in the tree:

https://kojipkgs.fedoraproject.org/compose/branched/Fedora-25-20160810.n.0/compose/Spins/armhfp/images/Fedora-Minimal-armhfp-25-20160810.n.0-sda.raw.xz

But it is not listed at all in the images.json metadata:

https://kojipkgs.fedoraproject.org/compose/branched/Fedora-25-20160810.n.0/compose/metadata/images.json

There may be other missing images, this is just one that I noticed.


This is caused by my misunderstanding of how these images work: there used to be a check that if metadata says an image is bootable, it needs to contain MBR, GPT or El Torito section. This however only only applies to x86_64 and i386, arm images can be booted without anything else. The check was removed in #358. Pungi 4.1.8 should include the patch.

If you look at the end of global log, you can see all the failed checks.

When the check failed, the image gets removed from metadata. It should probably also be removed from the tree, but currently it is not. Maybe we should just drop the check. What do you think?

Let's see if this happens again with newer pungi.

I would say either remove the actual image file or don't remove it from the metadata, yeah.

Checking whether the ISO is bootable is, I mean, a reasonable thing to do I guess (but whether it's pungi's job seems more arguable? good a place as any I guess), but I don't really see the purpose of removing an image if it's not bootable. Surely that fact should just be recorded somewhere. I mean, for a start, you probably want to keep the ISO around in order to help debug why it's not bootable...

The original intent was to catch issues like we had in F24 cycle with not running isohybrid and the image not being bootable from USB stick. Unfortunatelly it does not work as well as I imagined.

Current code only prints a message in log when something looks wrong.

@lsedlar changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata