#338 enable some artifcats to fail
Closed: Fixed 7 years ago Opened 7 years ago by ausil.

some of the secondary artifacts, livecd's, images, arm disk images can fail, and others can not, for each one we should have an optionable failable flag


'^Docker$': [
{
'image-build': {
'failable': True,
'format': [('docker', 'tar.xz')],
'name': 'Fedora-Docker-Base',
'target': 'f24',
'version': '24',
'release': None,
# correct SHA1 hash will be put into the URL below automatically
'ksurl': 'git+https://pagure.io/fedora-kickstarts.git?#origin/f24',
'kickstart': 'fedora-docker-base.ks',
'distro': 'Fedora-20',
'disk_size': 3,
'arches': ['x86_64', 'armhfp'],
'repo': 'http://kojipkgs.fedoraproject.org/pub/alt/releases/24/Cloud/$arch/os/',
'install_tree_from': 'http://kojipkgs.fedoraproject.org/pub/alt/releases/24/Cloud/$arch/os/',
'subvariant': 'Docker_Base'
}
}
],


perhaps we do not want failable to be binary, maybe have it be a list of arches and * for all


'failable': ['*'],


'failable': ['i386', 'ppc64', 'ppc64le'],

This would work great for cases where the config already contains a section into which we can add this. However, for buildinstall and creating ISOs there is no place where to add this. Since there is always only one "artifact" per variant/arch combination in this case, the current configuration is precise enough in my opinion.

I'm not sure though if it is a good idea to have the failability configurable in two different ways.

well KDE and Workstation for instance are relase blocking and can not fail, if they do the compse needs to fail. we may need that same ability for buildinstall. at the least buildinstall needs to be able to fail on some arches. perhaps we need to sit back and have one way to configure things.

Workstation is a separate variant, there should be no problem configuring that. KDE is a live media in Spins variant, so this kind of configuration would work there as well.

Proposed configuration would work great for ostree and ostree_installer with changes just in Pungi.

For live-images, live-media and image-build we don't have control over different arches without some change in Koji, but still the proposed config would work (at first we can look at it as a boolean value: if some arch is specified, it can fail).

The new osbs phase does not care about arches at all, but the proposal would still work great there.

I will put together a draft of how this could work, we can test it and decide where to go from there.

I opened a PR with the draft, it's #339.

We now have better granularity at artifact level. The last part missing is being able to configure this per-arch. That is issue #128.

@lsedlar changed the status to Fixed

7 years ago

Login to comment on this ticket.

Metadata