#31 make CHECKSUM files with a single type of hashing algorithm
Closed: Fixed None Opened 8 years ago by ausil.

In Fedora we have always made a single CHECKSUM file in iso directories. we actively do not surpport md5sum or sha1sum, we need to be able to tweak the way we make the checksum files


Hello Dennis,

I'm planning some rewrite of the checksum part since. RHEL-6 alters boot.iso in further phases after it's creation.

This forces me to move checksum calculation phase somewhere outside of createiso or recaulculate checksums at right spot after modification of images (which is the least preferred one).

And good plan would be to make have media_checksums = ["sha256" "sha1","md5"] , where we could specify variety of checksums. Where default would be the current behavior which is all of the mentioned.

Sounds good?

Lubos

Hello Dennis,

I'm planning some rewrite of the checksum part since. RHEL-6 alters boot.iso in further phases after it's creation.

This forces me to move checksum calculation phase somewhere outside of createiso or recaulculate checksums at right spot after modification of images (which is the least preferred one).

And good plan would be to make have media_checksums = ["sha256" "sha1","md5"] , where we could specify variety of checksums. Where default would be the current behavior which is all of the mentioned.

Sounds good?

Lubos

I think it is fine. ideally we would like to keep the checksum files ending in CHECKSUM and not SHA256SUM

I have opened pull request #67 which moves the checksum computing into a separate phase and allows users to configure which types they want and how it should be stored. Default configuration has the same behaviour as before. For Fedora, the configuration should additionally include

media_checksums = ["sha256"]
media_checksum_one_file = True  # to generate single CHECKSUM file instead
                                # of per-image file

We now can make a single CHECKSUM, but we broke making DVD's in the process.

Note: the dvds was tracked in #77.

Login to comment on this ticket.

Metadata