Learn more about these different git repos.
Other Git URLs
Related to PR #230 we need to be able to dynamically work out where the templates are located depending on the version of lorax so we don't need to hard code locations.
looking at the lorax code find_templates only exists in the f24-branch and master.
pungi is actually doing terrible things here. it is making assumptions on the compose box where the templates will be in the runroot environment. we are going to have to run something in the chroot that will tell us or we need to move to making the DVD as part of the process that makes the install tree. which is what pungi cli does
In my opinion th best solution would be to add a configuration option to specify the path so that there is no guessing. See #235. For lack of better name I called it iso_boot_option_map, which is not really descriptive, but I don't know exactly what this path means.
iso_boot_option_map
Another solution would be to modify the command in runroot task to call pylorax, find the correct path and substitute that into proper place (with some fallback if pylorax is not available). This is not easy to implement as I can't bypass some of the quoting.
runroot
Technically, we could hack it and run a separate runroot task to find the directory (example), put it into the command on the compose box and then continue as usual. The code is not that difficult (#234), but it is not really a solution.
I think if we write a command in pungi that makes the dvd iso and is able to figure it out is best. we then change the runroot call to install pungi, execute the command to make the dvd. its all then nicely contained. and we do not make any assumptions on the runroot environment
Commit bb2a682 fixes this issue
Login to comment on this ticket.