#1756 pungi not marking failed composes DOOMED and not emitting doomed message
Closed: Fixed a year ago by lsedlar. Opened a year ago by kevin.

Branched compose failed last night:

https://kojipkgs.fedoraproject.org/compose/branched/Fedora-40-20240413.n.0/logs/global/pungi.global.log

https://kojipkgs.fedoraproject.org/compose/branched/Fedora-40-20240413.n.0/logs/global/traceback.global.log

due to a failed workstation build.

However, the compose still shows status "STARTED" and never emits the failed message. ;(

pungi-4.6.2-4.fc39.noarch


This is indeed strange.

It's perfectly possible for a task to fail and then pungi taking a lot of time to notice that (due to how the parallelism is implemented). That happened here in a way. The task failed at 11:07:27 UTC, but the log about it is from 12:49:27.

But even then the compose should have correct status. For some reason the traceback file is now empty as well.

This is the e-mail from cron, which has a hint at the end.

2024-04-13 12:49:27 [ERROR   ] Extended traceback in:
/mnt/koji/compose/branched/Fedora-40-20240413.n.0/logs/global/traceback.global.log
Traceback (most recent call last):
...
  File "/usr/lib/python3.12/site-packages/pungi/phases/livemedia_phase.py", line
122, in _run_command
    raise RuntimeError(RuntimeError: Live media task failed: 116308609. See /mnt/koji/compose/branched/Fedora-40-20240413.n.0/logs/aarch64-x86_64/livemedia-Spins-KDE.aarch64-x86_64.log for more details.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/bin/pungi-koji", line 33, in <module>
    sys.exit(load_entry_point('pungi==4.6.2', 'console_scripts', 'pungi-koji')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/pungi/scripts/pungi_koji.py", line 696, in cli_main
    COMPOSE.traceback(show_locals=getattr(ex, "show_locals", True))
  File "/usr/lib/python3.12/site-packages/pungi/compose.py", line 722, in traceback
    f.write(kobo.tback.Traceback(show_locals=show_locals).get_traceback())
TypeError: a bytes-like object is required, not 'str'

This is caused by kobo making a backwards incompatible change in version 0.36.0. It now returns str instead of bytes: https://github.com/release-engineering/kobo/pull/246

PR #1757 should make pungi accept both types.

Thanks for tracking this down.

Log in to comment on this ticket.

Metadata
Related Pull Requests
  • #1757 Merged a year ago