Issue #1565: check_image_metadata() fails for RHCEPH composes - pungi

pungi

#1565 check_image_metadata() fails for RHCEPH composes

Closed: Fixed 2 years ago by lsedlar. Opened 2 years ago by ktdreyer.

I'm seeing a crash related to PR #1564 . Here's the traceback I'm seeing when I'm running Pungi master for RHCEPH 5 composes:

Traceback (most recent call last):
  File "/home/cloud-user/pungi/pungi/scripts/pungi_koji.py", line 668, in cli_main
    main()
  File "/home/cloud-user/pungi/pungi/scripts/pungi_koji.py", line 350, in main
    latest_link_components=latest_link_components,
  File "/home/cloud-user/pungi/pungi/scripts/pungi_koji.py", line 563, in run_compose
    test_phase.start()
  File "/home/cloud-user/pungi/pungi/phases/base.py", line 63, in start
    self.run()
  File "/home/cloud-user/pungi/pungi/phases/test.py", line 29, in run
    check_image_metadata(self.compose)
  File "/home/cloud-user/pungi/pungi/phases/test.py", line 58, in check_image_metadata
    return compose.images
  File "/usr/lib/python3.6/site-packages/productmd/compose.py", line 113, in images
    self._images = self._load_metadata(paths, productmd.images.Images)
  File "/usr/lib/python3.6/site-packages/productmd/compose.py", line 142, in _load_metadata
    path = self._find_metadata_file(paths)
  File "/usr/lib/python3.6/site-packages/productmd/compose.py", line 89, in _find_metadata_file
    raise RuntimeError('Failed to load metadata from %s' % self.compose_path)
RuntimeError: Failed to load metadata from /home/cloud-user/composes/RHCEPH-5.1-RHEL-8-20211103.t.0/compose

Full command from run-pungi was:

ERROR running command: pungi-koji --config=/home/cloud-user/rcm-metadata/pungi/ceph/ceph-5/ceph-5.1-rhel-8/main.conf --compose-dir=/home/cloud-user/composes/RHCEPH-5.1-RHEL-8-20211103.t.0 --test --old-composes=/home/cloud-user/composes --old-composes=/dev/null --skip-phase=createiso --no-label --no-latest-link

This system has python3-productmd-1.30-1.el8eng

ktdreyer commented 2 years ago

Some more information:

Ceph composes always run with --skip-phase=createiso since we have no per-variant ISOs.

In RHCEPH 3 and 4, we use pungi-create-unified-isos. Those composes have a images.json file in the productmd metadata directory.

In RHCEPH 5+, we have stopped providing the ISO to customers, so we don't use pungi-create-unified-isos, and there is no images.json in the productmd metadata directory at all.