#1424 test reuse path's before using
Closed: Fixed 3 years ago by lsedlar. Opened 3 years ago by kevin.

We ran into some issues with fedora composes that exposed an issue with pungi.

https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20200710.n.1.doomed/

failed due to a db error (the db hit OOM and crashed).

After that was fixed, re-running compose:

https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20200710.n.2/
https://kojipkgs.fedoraproject.org/compose/rawhide/Fedora-Rawhide-20200710.n.3/

crashed in:

TypeError: expected str, bytes or os.PathLike object, not NoneType

I think because it was trying to re-use the repos from .1, but it crashed before it even made any?


These composes do not exist now.

I moved them to a 'foo' subdirectory in order to get composes to complete.
https://kojipkgs.fedoraproject.org/compose/rawhide/foo/

Commit 05a5e2b fixes this issue

Metadata Update from @hlin:
- Issue set to the milestone: 4.2.4

3 years ago

Metadata Update from @mohanboddu:
- Issue set to the milestone: None (was: 4.2.4)
- Issue status updated to: Open (was: Closed)

3 years ago

It happened again with branched compose and I moved them to foo/ dir again

https://kojipkgs.fedoraproject.org/compose/branched/foo/Fedora-33-20200915.n.1/

I guess its happening whenever the previous compose is DOOMED

It failed when reusing pkgset arch repo, should check if old_repo_dir is None first.

Frame _create_arch_repo in /usr/lib/python3.8/site-packages/pungi/phases/pkgset/common.py at line 120:

     113     repo_dir = compose.paths.work.pkgset_repo(pkgset.name, arch=arch)
     114     paths[arch] = repo_dir
     115 
     116     # Try to reuse arch repo from old compose
     117     reuse = getattr(pkgset, "reuse", None)
     118     if reuse:
     119         old_repo_dir = compose.paths.old_compose_path(repo_dir)
-->  120         if os.path.isdir(old_repo_dir):
     121             msg = "Copying repodata for reuse: %s" % old_repo_dir
     122             try:
     123                 compose.log_info("[BEGIN] %s", msg)
     124                 copy_all(old_repo_dir, repo_dir)
     125                 compose.log_info("[DONE ] %s", msg)
     126                 return

Metadata Update from @lsedlar:
- Issue set to the milestone: 4.2.5

3 years ago

Login to comment on this ticket.

Metadata
Related Pull Requests
  • #1453 Merged 3 years ago
  • #1427 Merged 3 years ago