From 5693bf9925d01b95e5d00318e92c2073965cf352 Mon Sep 17 00:00:00 2001 From: Lubomír Sedlář Date: Jan 26 2017 09:55:23 +0000 Subject: repoclosure: Remove unused code There are a lot of options that are not used by any code path in Pungi. There is not reason to provide access to them. Signed-off-by: Lubomír Sedlář --- diff --git a/pungi/wrappers/repoclosure.py b/pungi/wrappers/repoclosure.py index 090b6db..0f0f7c1 100644 --- a/pungi/wrappers/repoclosure.py +++ b/pungi/wrappers/repoclosure.py @@ -24,33 +24,26 @@ class RepoclosureWrapper(object): def __init__(self): self.actual_id = 0 - def get_repoclosure_cmd(self, config=None, arch=None, basearch=None, builddeps=False, - repos=None, lookaside=None, tempcache=False, quiet=False, newest=False, pkg=None, group=None): + def get_repoclosure_cmd(self, arch=None, builddeps=False, + repos=None, lookaside=None): cmd = ["/usr/bin/repoclosure"] - - if config: - cmd.append("--config=%s" % config) - - if arch: - for i in force_list(arch): - cmd.append("--arch=%s" % i) - - if basearch: - cmd.append("--basearch=%s" % basearch) + # There are options that are not exposed here, because we don't need + # them. These are: + # --config + # --basearch + # --tempcache + # --quiet + # --newest + # --pkg + # --group + + for i in force_list(arch or []): + cmd.append("--arch=%s" % i) if builddeps: cmd.append("--builddeps") - if tempcache: - cmd.append("--tempcache") - - if quiet: - cmd.append("--quiet") - - if newest: - cmd.append("--newest") - repos = repos or {} for repo_id, repo_path in repos.iteritems(): if "://" not in repo_path: @@ -65,10 +58,4 @@ class RepoclosureWrapper(object): cmd.append("--repofrompath=%s,%s" % (repo_id, repo_path)) cmd.append("--lookaside=%s" % repo_id) - if pkg: - cmd.append("--pkg=%s" % pkg) - - if group: - cmd.append("--group=%s" % group) - return cmd