#923 Make Server armhfp unique in metadata
Merged 3 years ago by mohanboddu. Opened 3 years ago by lsedlar.
lsedlar/pungi-fedora server-armhfp-image  into  master

file modified
+3 -1
@@ -679,6 +679,7 @@ 

                  'repo': 'Everything',

                  'type': 'appliance',

                  'failable': True,

+                 'subvariant': 'Workstation_Appliance',

                  }

      }),

      ('^Server$', {
@@ -687,6 +688,7 @@ 

                  'name': 'Fedora-Server-armhfp',

                  'type': 'appliance',

                  'failable': True,

+                 'subvariant': 'Workstation_Appliance',

errrr

This should be Server_Appliance

                  }

      }),

      ('^Spins$', {
@@ -719,7 +721,7 @@ 

                  'name': 'Fedora-Minimal-armhfp',

                  'repo': 'Everything',

                  'type': 'appliance',

-                 'subvariant': 'Minimal',

+                 'subvariant': 'Minimal_Appliance',

                  'failable': False,

                  },

                  {

This should fix missing updates of the Cloud rawhide image. Either this image or the Server.armhfp appliance should have some different subvariant set. The actual value used shouldn't matter for this particular issue. It might matter for consumers of the metadata.

Are the images actually different? Should they both be generated?


When not specified, subvariant defaults to the variant. This leads to both armhfp Server images to have identical metadata. A file with such issue can not be loaded by productmd parser.

Due to another issue (that should be fixed in next Pungi release), the paths to image directories are not listed in composeinfo.json file. The compose-partial-copy script therefore has to find out if images should be copied from the image metadata. And since there's an error in it, it doesn't see the images and doesn't copy them.

rebased onto 5374885

3 years ago

@mohanboddu pointed out that this happens with multiple more images. I updated the patch to change the three appliances subvariant instead (by appending _Appliance, which is still a horrible name).

FYI I'm working on a proposal to move all the armhfp images over to imagefactory/UEFI for F-34 if that helps at all. Just need to a bunch of verification and I'm looking at some enhancements for those artefacts (both armhfp/aarch64).

Pinging @adamwill if this change needs any fixes on QA side.

This should be Server_Appliance

Pull-Request has been merged by mohanboddu

3 years ago
Metadata