#878 Fix locale installation on Server DVD
Merged 3 years ago by mohanboddu. Opened 3 years ago by sgallagh.
sgallagh/pungi-fedora serverdvd  into  master

file modified
+2 -1
@@ -128,10 +128,11 @@ 

              'autocorr-*',

              'eclipse-nls',

              'eclipse-nls-*',

+             'glibc-langpack-*',

              'hunspell-*',

              'hyphen-*',

              'kde-l10n-*',

-             'libreoffice-langpack-*',

+             'langpacks-*',

              'man-pages-*',

              'mythes-*',

          ],

While investigating BZ#1872511, we determined that we need to make sure all of the langpacks need to be on the install media so that Anaconda can write the correct /etc/locale.conf file. In addition, I also discovered that the libreoffice-langpack-* entry is what was pulling in the entire libreoffice and X11 suite into the DVD, so removing this should vastly decrease the size of the Server DVD.

@adamwill Could you have a look please?

Seems okay to me, yeah. The only thing I'd like to understand better is why we have this split between the variants definition file and this additional_packages in the config, but I feel like this ought to work at least. Maybe the variant definition can only list groups, not packages?

That's how I'm reading https://pagure.io/pungi/blob/master/f/share/variants.dtd yeah. It looks like the only packages that can be specified are those needed for the buildinstall step. Everything else has to be in a group.

I suppose the other option would be to create a new comps.xml group containing all of the langpacks, but since comps doesn't support globs, that would likely be impossible to maintain in the long-term.

Pull-Request has been merged by mohanboddu

3 years ago