PR#671: Make x86_64 container base image the only non failable image - pungi-fedora

pungi-fedora

#671 Make x86_64 container base image the only non failable image

Closed 5 years ago by cverna. Opened 5 years ago by cverna.

cverna/pungi-fedora allow_container_arches_fail into master

Add a comment to explain Fedora-22

Clement Verna • 5 years ago

32b749f

Make x86_64 container base image the only non failable image

Clement Verna • 5 years ago

4a69808

fedora-container.conf

file modified

+6 -4

		`@@ -222,15 +222,16 @@`
		`'format': [('docker', 'tar.xz')],`
		`'name': 'Fedora-Container-Base',`
		`'kickstart': 'fedora-docker-base.ks',`
		`- 'distro': 'Fedora-22',`
		`+ 'distro': 'Fedora-22', # Use by koji to define Fedora with dnf instead of yum`
		`'disk_size': 5,`
		`'arches': ['armhfp', 'aarch64', 'ppc64le', 's390x', 'x86_64'],`
		`'install_tree_from': 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/',`
		`'repo': [`
		`'https://kojipkgs.fedoraproject.org/compose/updates/f29-updates/compose/Everything/$arch/os/'`
		`- 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/'`
		`+ 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/'`
		`],`
		`- 'subvariant': 'Container_Base'`
		`+ 'subvariant': 'Container_Base',`
		`+ 'failable': ['armhfp', 'aarch64', 'ppc64le', 's390x'],`
		`},`
		`'factory-parameters': {`
		`'dockerversion': "1.10.1",`
		`@@ -250,9 +251,10 @@`
		`'install_tree_from': 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/',`
		`'repo': [`
		`'https://kojipkgs.fedoraproject.org/compose/updates/f29-updates/compose/Everything/$arch/os/'`
		`- 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/'`
		`+ 'https://kojipkgs.fedoraproject.org/compose/29/latest-Fedora-29/compose/Everything/$arch/os/'`
		`],`
		`'subvariant': 'Container_Minimal_Base',`
		`+ 'failable': ['armhfp', 'aarch64', 'ppc64le', 's390x'],`
		`},`
		`'factory-parameters': {`
		`'dockerversion': "1.10.1",`

no initial comment

dustymabe commented 5 years ago

LGTM

pbrobinson commented 5 years ago

aarch64 containers are primary too so they should not be failable either so NAK on this

cverna commented 5 years ago

aarch64 containers are primary too so they should not be failable either so NAK on this

Out of curiosity, where can I see what is primary or not ?

mohanboddu commented 5 years ago

@cverna https://fedoraproject.org/wiki/Architectures Although I guess it needs some updates.

Edited 5 years ago by mohanboddu

cverna commented 5 years ago

@cverna https://fedoraproject.org/wiki/Architectures Although I guess it needs some updates.

So looking at this armhfp is also primary, which means that we want to fail the compose if the build fails.
Since these PRs were mostly to have a valid compose despite of armhfp failing I guess I can close these PRs.

Edited 5 years ago by cverna