#621 Stop sending empty changelogs on failure
Merged 5 years ago by mohanboddu. Opened 5 years ago by lsedlar.
lsedlar/pungi-fedora no-empty-changelog  into  master

file modified
+13 -1
@@ -87,7 +87,19 @@ 

  # Fix permissions on the grub efi files and fonts (they're 0600)

  chmod -R go+r $DESTDIR/compose/*/*/os/EFI/

  

- compose-changelog -p $DESTDIR/logs/ $TARGET_DIR/$OLDCOMPOSE_ID/ $DESTDIR/

+ if ! compose-changelog -p "$DESTDIR/logs/" "$TARGET_DIR/$OLDCOMPOSE_ID/" "$DESTDIR/" 2>"$DESTDIR/logs/changelog.stderr"; then

+     # Generating changelog failed. We should not send an empty announcement to

+     # general public.

+     TOMAIL=""

+     VERSION="$(rpm -q compose-utils)"

+     # Instead report it to rel-eng@ list.

+     mutt -e "set from=\"$FROM\"" \

+         -e 'set envelope_from=yes' \

+         -s "Generating changelog for $NEWCOMPOSE_ID failed (with $VERSION)" \

+         rel-eng@lists.fedoraproject.org \

+         < "$DESTDIR/changelog.stderr"

+ fi

+ 

  # Figure out a version for broken deps e-mail that goes to package maintainers.

  # In Rawhide it's just rawhide, for branched versions we prepend F- to the number.

  if [ "$RELEASE" = "rawhide" ]; then

If there's a problem, the changelog will be empty, which is not particularly helpful to anybody. Instead of spamming devel@ list with that, just send the traceback to rel-eng@.

rebased onto 995f2c6

5 years ago

Pull-Request has been merged by mohanboddu

5 years ago
Metadata