PR#1435: Allow container-toolbox to fail on ppc64le and s390x - pungi-fedora

pungi-fedora

#1435 Allow container-toolbox to fail on ppc64le and s390x

Merged 3 months ago by kevin. Opened 3 months ago by adamwill.

adamwill/pungi-fedora toolbox-failable into main

Allow container-toolbox to fail on ppc64le and s390x

Adam Williamson • 3 months ago

bf59b47

fedora.conf

file modified

+1 -1

		`@@ -343,7 +343,7 @@`
		`'subvariant': 'Container_Toolbox',`
		`'target': global_target,`
		`'bundle_name_format': '%N-%v-%I.%A.%T',`
		`- 'failable': [''],`
		`+ 'failable': ['s390x', 'ppc64le'],`
		`},`
		`{`
		`'kiwi_profile': 'FEX-RootFS',`

adamwill commented 3 months ago

These are not release-blocking arches. Nothing on them should
fail the compose. See
https://pagure.io/releng/failed-composes/issue/7711#comment-951258

Signed-off-by: Adam Williamson awilliam@redhat.com

zuul commented 3 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/6e6017fb8a9a4cb4a288d6dd65d402f0

pungi-config-validate : SUCCESS in 2m 10s
validate-variants : SUCCESS in 2m 06s

ngompa commented 3 months ago

:thumbsup:

kevin commented 3 months ago

I suppose. I recall when we added toolbox that maintainers wanted everything to be failable, but that may have well been before we could build s390x/ppc64le containers (ie, back in the OSBS days).

CC: @rishi

Pull-Request has been merged by kevin

3 months ago

adamwill commented 3 months ago

The decision about what's failable is more of a releng decision than an individual component maintainer decision, I'd say, as it affects everybody. I'm pretty sure we've always held that deliverables for non-release-blocking arches must be failable (i.e. must not fail the compose).

kevin commented 3 months ago

Yeah, really a fesco decision... but there was a change to make toolbox release blocking and neither in the change or the discussion I could find was a mention of what arches it applied to. ;(

adamwill commented 3 months ago

Well, only x86_64 and aarch64 were added to https://docs.fedoraproject.org/en-US/releases/f41/blocking/ , so this matches that.

rishi commented 3 months ago

I didn't realize that we are now building OCI images for ppc64le and s390x. That's fantastic. Just out of curiosity, is that a consequence of using Kiwi or something else?

When I had submitted the ToolbxReleaseBlocker Change for Fedora 39, I was aware of only the aarch64 and x86_64 images, and my intention was to make Toolbx release-blocking on only those architectures that are release-blocking for Fedora in general. So, I won't complain about letting the Toolbx image fail on ppc64le and s390x. :)

I am happy to help fix the failures, though.

kevin commented 3 months ago

Yeah, the old OSBS system only had x86_64 and aarch64 clusters (you had to make a openshift cluster for each arch).