PR#1423: [main] Add Zuul CI - pungi-fedora

pungi-fedora

#1423 [main] Add Zuul CI

Merged 9 days ago by kevin. Opened a month ago by yselkowitz.

yselkowitz/pungi-fedora main into main

Add variants-fedora.xml validation

Yaakov Selkowitz • a month ago

a3f2d95

Add schema override

Yaakov Selkowitz • a month ago

2d009ba

Add Zuul CI

Yaakov Selkowitz • a month ago

372421f

.zuul.yaml

file added

+15

		`@@ -0,0 +1,15 @@`
		`+ - project:`
		`+ check:`
		`+ jobs:`
		`+ - pungi-config-validate`
		`+ - validate-variants`
		`+`
		`+ - job:`
		`+ name: pungi-config-validate`
		`+ description: Validate pungi configs`
		`+ run: ci/pungi-config-validate.yaml`
		`+`
		`+ - job:`
		`+ name: validate-variants`
		`+ description: Validate variants-fedora.xml file`
		`+ run: ci/validate-variants.yaml`

ci/pungi-config-validate

file added

+26

		`@@ -0,0 +1,26 @@`
		`+ #!/usr/bin/bash`
		`+`
		`+ set -euo pipefail`
		`+`
		`+ main() {`
		`+ failure=0`
		`+`
		`+ args=`
		`+ if [ -f override.json ]; then`
		`+ args="--schema-override override.json"`
		`+ fi`
		`+`
		`+ for f in fedora*.conf; do`
		`+ pungi-config-validate $args $f > /dev/null 2>&1 \|\| {`
		`+ echo "Validation of $f failed!"`
		`+ ((failure+=1))`
		`+ }`
		`+ done`
		`+`
		`+ if [[ $failure -gt 0 ]]; then`
		`+ echo "${failure} check(s) failed!"`
		`+ exit 1`
		`+ fi`
		`+ }`
		`+`
		`+ main "${@}"`

ci/pungi-config-validate.yaml

file added

+11

		`@@ -0,0 +1,11 @@`
		`+ - hosts: all`
		`+ tasks:`
		`+ - name: Install needed packages`
		`+ package:`
		`+ name: ['pungi-utils']`
		`+ state: present`
		`+ become: yes`
		`+ - name: Validate pungi configs`
		`+ ansible.builtin.command:`
		`+ chdir: "{{ zuul.project.src_dir }}"`
		`+ cmd: ci/pungi-config-validate`

ci/validate-variants

file added

+19

		`@@ -0,0 +1,19 @@`
		`+ #!/usr/bin/bash`
		`+`
		`+ set -euo pipefail`
		`+`
		`+ main() {`
		`+ failure=0`
		`+`
		`+ xmllint --noout variants-fedora.xml > /dev/null 2>&1 \|\| {`
		`+ echo "Validate failed!"`
		`+ ((failure+=1))`
		`+ }`
		`+`
		`+ if [[ $failure -gt 0 ]]; then`
		`+ echo "${failure} check(s) failed!"`
		`+ exit 1`
		`+ fi`
		`+ }`
		`+`
		`+ main "${@}"`

ci/validate-variants.yaml

file added

+11

		`@@ -0,0 +1,11 @@`
		`+ - hosts: all`
		`+ tasks:`
		`+ - name: Install needed packages`
		`+ package:`
		`+ name: ['libxml2']`
		`+ state: present`
		`+ become: yes`
		`+ - name: Validate variants.xml file`
		`+ ansible.builtin.command:`
		`+ chdir: "{{ zuul.project.src_dir }}"`
		`+ cmd: ci/validate-variants`

override.json

file added

		`@@ -0,0 +1,5 @@`
		`+ {`
		`+ "properties": {`
		`+ "KIWI_ISO_VOLID_VERSION": {"type": "string"}`
		`+ }`
		`+ }`

yselkowitz commented a month ago

fedora.conf currently reports WARNING: Unrecognized config option: KIWI_ISO_VOLID_VERSION. p-c-v doesn't seem to like custom variables; is there a "proper" way to fix/avoid this?

zuul commented a month ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/2b7bc2883ab34213b60544e3b4223726

pungi-config-validate : FAILURE in 2m 16s

yselkowitz commented a month ago

FWIW this works as-is with f41, f40, and (once modified to use epel.conf instead of fedora*.conf) epel10 branches.

kevin commented a month ago

I am not sure how to avoid those warnings. Perhaps @lsedlar knows?

But yeah, they are just warnings...

yselkowitz commented a month ago

They are warnings, but p-c-v exits 1 even then. Only a completely clean config exits 0. Unless we just can't/shouldn't rely on the exit code for this?

yselkowitz commented a month ago

It seems a schema override might be in order here: https://pagure.io/pungi/pull-request/1341 ?

rebased onto dbfae3a

a month ago

yselkowitz commented a month ago

This version allows for an optional override.json file to define the custom variables (seen as unknown properties otherwise). Let me know if you prefer a different name for this file.

zuul commented a month ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/13ebee39d38b4152bdd3448b12793c92