#1195 toolbox: should be blocking (f39)
Merged 9 months ago by kevin. Opened 9 months ago by kevin.
Unknown source toolbox-blocking-f39  into  f39

file modified
+1 -1
@@ -256,7 +256,7 @@

                      'repo': 'Everything',

                      'install_tree_from': 'Everything',

                      'subvariant': 'Container_Toolbox',

-                     'failable': ['*'],

+                     'failable': [''],

                      },

              'factory-parameters': {

                  'dockerversion': "1.10.1",

I marked toolbox as failable when we were getting everthing working on
it (and so we would still have composes). Now that it's working, lets
mark it blocking again.

Signed-off-by: Kevin Fenzi kevin@scrye.com

In the last compose I checked, it failed on s390x and ppc64le - https://koji.fedoraproject.org/koji/taskinfo?taskID=105067291 . would marking it as failable '' mean the compose dies if it fails on s390x or ppc64le?

That would be the idea, no?

I guess, I was just worried that if those are recurring issues rather than one-offs, we'll be unable to get composes done...but I just checked the last two days' worth of composes and I don't see Toolbx failures there, so I guess it's OK.

In the last compose I checked, it failed on s390x and ppc64le - https://koji.fedoraproject.org/koji/taskinfo?taskID=105067291 . would marking it as failable '' mean the compose dies if it fails on s390x or ppc64le?

Yes, the '*' wildcard in compose config is expanded to all arches and passed to koji as optional_arches, so any failing subtask still results in successful parent task (and even failure there would not abort the compose).

If you want to ignore failures only on some arches, list those in the pungi config: "failable": ["ppc64le", "s390x"] would ignore errors only on those.

Given that the option should be a list of arches or *, the empty string is suspicious, but I think it should behave the same as if there was nothing.

Pull-Request has been merged by kevin

9 months ago
Metadata