#679 zchunk metadata is missing zdicts
Closed: Fixed 11 months ago Opened a year ago by jdieter.

First off, thanks so much for turning on the zchunk metadata creation in createrepo_c. It looks like it's working fine, but the zchunk files are extremely large because they're missing the zdicts available in fedora-repo-zdicts.

This is either because fedora-repo-zdicts isn't installed or because my patch in #678 is wrong. The correct path for the zdicts should be /usr/share/fedora-repo-zdicts/f30 or /usr/share/fedora-repo-zdicts/rawhide.

If fedora-repo-zdicts isn't installed on the systems running creatrepo_c, can we please install it? If the problem is that %(pkgset_koji_tag) doesn't resolve to 'f30' or 'rawhide', then my patch is wrong, and I'd love some guidance on what variable would be a better choice.

Thanks again for enabling zchunk metadata generation!


It is installed, I think perhaps it's not expanding the %(pkgset_koji_tag) ?

@lsedlar might know whats going on here...

There is no expansion like that implemented. The value will have to be hardcoded for now.

Ok, @lsedlar, thanks for the heads up. I've submitted https://pagure.io/pungi-fedora/pull-request/680 that hardcodes the value for now.

I can easily change the directory that fedora-repo-zdicts stores the zdicts in, so is there an expansion that would be easier to use?

Pungi does not do anything special with the value, but kobo (the library we use for parsing the config) has its own string interpolation that can use any option already defined in the config.

This patch should work (assuming the path can use f30 instead of rawhide).

-createrepo_extra_args = ['--zck', '--zck-dict-dir=/usr/share/fedora-repo-zdicts/rawhide']
+createrepo_extra_args = ['--zck', '--zck-dict-dir=/usr/share/fedora-repo-zdicts/%s' % pkgset_koji_tag]

If you have pungi-utils package installed, you can run pungi-config-dump fedora.conf and see in the output how the value would be expanded.

Pungi does not do anything special with the value, but kobo (the library we use for parsing the config) has its own string interpolation that can use any option already defined in the config.

If you have pungi-utils package installed, you can run pungi-config-dump fedora.conf and see in the output how the value would be expanded.

Thanks so much for this! It works perfectly! And thanks for the pointer to pungi-config-dump, that made it easy to verify that it's correct.

I've gone ahead and submitted https://pagure.io/pungi-fedora/pull-request/682 as an update to PR 680.

Metadata Update from @jdieter:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

11 months ago

I went ahead and closed this issue as the metadata has had the zdicts since December 27ish.

Login to comment on this ticket.

Metadata