PR#63: BZ summary: Do not override a good error message with a bad one - pkgdb2

pkgdb2

#63 BZ summary: Do not override a good error message with a bad one

Merged 6 years ago by pingou. Opened 7 years ago by churchyard.

churchyard/pkgdb2 summary_parse into master

BZ summary: Do not override a good error message with a bad one

Miro Hrončok • 6 years ago

8faa6da

pkgdb2/api/extras.py

file modified

+1 -1

		`@@ -803,7 +803,7 @@`
		`'present)'`

		`# Check the format of the title`
		`- if not ' - ' in tmp:`
		`+ if tmp and not ' - ' in tmp:`
		`httpcode = 400`
		`output['output'] = 'notok'`
		`output['error'] = 'Invalid title for this bugzilla ticket (no "-" '\`

churchyard commented 7 years ago

Fixes https://pagure.io/pkgdb2/issue/62

pingou commented 6 years ago

I just found out about this PR :-s sorry about that.

The change itself looks good, would you mind rebasing so I can merge it?
I realize pkgdb is going away in Fedora fairly soon but there is at least one more pkgdb instance running that could benefit from this fix.

Thanks!

rebased

6 years ago

churchyard commented 6 years ago

Done.