1) I think now pkgdb2 sending emails for every user action as "<fasuser> updated <pkg>" which should be changed back to different subject messages depending on user actions like for request "<pkgname>:<fasuser> has requested commit"
similar change for when user requested/granted watchcommits, watchbugzilla, user requested approveacls.
2) In the message itself now there is no web URL like this To make changes to this package see: https://admin.fedoraproject.org/pkgdb/acls/name/<pkgname>
3) In the message like this user: <user> set for <user> acl: commit of package: <pkgname> from: Awaiting Review to: Awaiting Review on branch: f19
I think initial value should be like either "nothing" or "". This is confusing to end user that state is same before and after => Awaiting Review.
Thanks for your inputs.
Please note that pkgdb2 is currently sending emails but ultimately it should not. The notifications should happen in the future via FMN [1] and we only turned it on for the moment while we are consolidating FMN.
1) This implies a little change in the logic, I'll see what I can do
2) Done in https://git.fedorahosted.org/cgit/pkgdb2.git/commit/?id=4b2078a042e5ec76e38a4edc49e5a1aedc4f1f35
3) This is an error in the code which I think I just found, it happens when someone clicks twice on "Request Commit Access"
[1] https://apps.fedoraproject.org/notifications/
Point 3 fixed at : https://git.fedorahosted.org/cgit/pkgdb2.git/commit/?id=b5ad10537d2b5aa625cafb9f3033a551c325db9d
This should address the first point: https://git.fedorahosted.org/cgit/pkgdb2.git/commit/?id=cf2a7c55653550269948dd76d10569720cdf39b6
It might be ideal, so suggestions are still welcome :)
Log in to comment on this ticket.