#51 "Builds status" link should use HTML escapes
Closed: Fixed None Opened 8 years ago by barsnick.

The pkgdb web page for a package, such as
https://admin.fedoraproject.org/pkgdb/package/rpms/dvd+rw-tools/
creates a set of links to "Builds status", "Updates status", "Package source", "Bug reports" and so on.

While all the latter links work, the first one doesn't. It points to:
http://koji.fedoraproject.org/koji/search?type=package&match=glob&terms=dvd+rw-tools

but while the '+' without HTML escape is okay for most URLs, for CGI params it isn't. So the constructed URL for this example should read:

http://koji.fedoraproject.org/koji/search?type=package&match=glob&terms=dvd%2Brw-tools

In other words, the package name should be HTML/URL-escaped. (The '+' is likely the only character valid in a package name but not in a URL, but I'm not sure about others. Any non-ASCII valid in package names? "äöüß" and so on?)

For the record:
It doesn't help if I call the original pkgdb page with escapes:
https://admin.fedoraproject.org/pkgdb/package/rpms/dvd%2Brw-tools/
Obviously, because the server (and the HTTP transfer of the URL) shouldn't see a difference.

According to the pkgdb created web page, this is version 2.0.2. I can't select that in this ticket's version field. :-P


Thanks for the report, I'll look into fixing this.

For the record, non-ascii characters are not allowed in package name: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Common_Character_Set_for_Package_Naming

Ok, I have the fix for this, will be up for review shortly

Login to comment on this ticket.

Metadata