The file typically installed in /etc/pkgdb2/pkgdb2.cfg has some variables missing quotes and if you're not programming in Python every day this is not obvious when you go to do a fresh installation.
Non-Fedora installations will need to point to their own OpenID system. The variables for this are not present in the default config file. Could you add them?
The DB_URL lines for MySQL and PostgreSQL.
Fixed in https://github.com/fedora-infra/pkgdb2/commit/38cffd655edde9bca70e20aa33f5a2a4f5a43bb2
FAS user/password variables. (comment could say quotes are required)
These are None in the sample configuration file and None is a valid python object, it does not need quotes.
For the last two (FAS_OPENID_ENDPOINT, FAS_OPENID_CHECK_CERT) they are not configuration keys from pkgdb2 but from FedOAuth, so I don't think we should document them in the sample configuration file, but I would welcome a small paragraph/page on the pkgdb2 documentation explaining how to get pkgdb2 running outside of the Fedora infrastructure.
Would you be interested in writing such a paragraph/page?
Replying to [comment:1 pingou]:
FAS user/password variables. (comment could say quotes are required) These are None in the sample configuration file and None is a valid python object, it does not need quotes.
Yes, I know, but when someone replaces None with real values they may forget to add quotes. It may be trivial to argue about, but I think it is worth arguing.
For the last two (FAS_OPENID_ENDPOINT, FAS_OPENID_CHECK_CERT) they are not configuration keys from pkgdb2 but from FedOAuth, so I don't think we should document them in the sample configuration file, but I would welcome a small paragraph/page on the pkgdb2 documentation explaining how to get pkgdb2 running outside of the Fedora infrastructure. Would you be interested in writing such a paragraph/page?
Sure, because offering the source code is only useful if pkgdb could be used outside of the Fedora infrastructure. :)
When are you switching away from FedOAuth to Ipsilon? The paragraph would need to change at that time.
What do you think of including it in the documentation itself? Maybe a section at: http://pkgdb2.readthedocs.org/en/latest/configuration.html
attachment 0001-doc-Add-FAS-FedOAuth-variable-definitions.patch
OK. What about the attached patch?
Merged and pushed.
Thanks!
Login to comment on this ticket.