#14 can't list packages of pseudousers
Closed: Fixed None Opened 9 years ago by petersen.

The old pkgdb supported listing the packages of a pseudouser
but it seems pkgdb2 does not yet.

Could you please add that support since it is very useful.

eg https://admin.fedoraproject.org/pkgdb/packager/i18n-team/
and https://admin.fedoraproject.org/pkgdb/packager/haskell-sig/ etc

Thanks!


Cc'ing Toshio that we look at it since apparently some pseudo-user are there
https://admin.fedoraproject.org/pkgdb/packager/perl-sig/

Some experimentation shows several related issues. For the issue noted at the top, it looks like maintainers who only have watchbugzilla and watchcommit do not get treated as a packager for the listing pages. (Tested by adding a commit acl for a single package for the haskell-sig user. They then had a packager/haskell-sig page with all of their entries.) I think it would be okay to change that.

While looking at that, I found that we can't add pseudo-users via the webui because they aren't in the packager group. I'm not sure what we want to do there. There's several options:

  • We can change these to fas groups of type packager. I think this is what we'd eventually want to transition to anyhow as pkgdb2 has preliminary support for groups.
  • We can add these users to the packager group. That would require them to be added to cla_done as well. Not a big deal (especially because we disable password and ssh key in the fas db for them) but still a little strange.
  • We can special-case bot accounts to be addable as package poc and comaint. Special cases never make me happy but we could keep this option in mind if the other options prove more difficult than we anticipate.

Regarding displaying:

  • It should be easy to list the packages of the pseudo-user just like we do for any packager, but the question is: should they appear in the list of packager? (I'll tend to say no).

  • The other thing, is that I believe this pseudo-user are meant to disappear in the long term and be replaced by FAS groups (of type pkgdb ;-)). Then we'll have to update the database to insert group:: in front of them.

In theory everything is there in pkgdb2 for group support, the only things missing are a) more testing b) adjusting the different cron tasks to support groups.

Replying to [comment:4 pingou]:

  • It should be easy to list the packages of the pseudo-user just like we do for any packager, but the question is: should they appear in the list of packager? (I'll tend to say no).

I am not familiar with the internals, so not sure on the implication of your comments.

I think it would be useful to list "Package watched" for pseudousers,
as a workaround at least until FAS Groups are available.

(BTW it should be "Packages watched:".
"Point of contact" also seems slightly vague to me:
I feel the older "Owned Packages" was clearer.)

  • The other thing, is that I believe this pseudo-user are meant to disappear in the long term and be replaced by FAS groups (of type pkgdb ;-)). Then we'll have to update the database to insert group:: in front of them.

I am not sure how groups work?
If I am guessing/remembering correctly they would be like a group acl?
Allowing members of that group to commit to packages with the group as owner or comaintainer?

+1 for FAS groups then

Replying to [comment:5 petersen]:

Replying to [comment:4 pingou]:

  • It should be easy to list the packages of the pseudo-user just like we do for any packager, but the question is: should they appear in the list of packager? (I'll tend to say no).

I am not familiar with the internals, so not sure on the implication of your comments.

I think it would be useful to list "Package watched" for pseudousers,
as a workaround at least until FAS Groups are available.

Ok so the core of the problem here is that is searches for packagers among the people that have commit ACLs, and it seems that most pseudo users only have watch*.

(BTW it should be "Packages watched:".
"Point of contact" also seems slightly vague to me:
I feel the older "Owned Packages" was clearer.)

Packages is fixed, for point of contact see https://fedorahosted.org/pkgdb2/ticket/8 (basically it's by design and won't change)

  • The other thing, is that I believe this pseudo-user are meant to disappear in the long term and be replaced by FAS groups (of type pkgdb ;-)). Then we'll have to update the database to insert group:: in front of them.

I am not sure how groups work?
If I am guessing/remembering correctly they would be like a group acl?
Allowing members of that group to commit to packages with the group as owner or comaintainer?

Groups are created in FAS, they must end with '-sig' and be of the pkgdb type and require the people in it to be in the packager group.

They can then be added as co-maintainer of a package and anyone in the group would get watch* and commit access.

Note: groups cannot have approveacls.

Great thanks!

Any idea when 1.10 may get deployed? :)

Build in progress ;-)

Thank you! That's nice.

How about pkgdb-cli?

eg:
{{{
$ pkgdb-cli list --user i18n-team
No packages found for these parameters
}}}

pkgdb-cli only returns package for which the user is point of contact for the moment. I'll need to add a --all argument I think.

Thanks pingou, you rock!

Login to comment on this ticket.

Metadata