PR#5464: tests(CI): Disable F39 RPM because of pytest+xdist bug. Pass REPO and BRANCH env vars as build-args to podman build. - pagure

pagure

#5464 tests(CI): Disable F39 RPM because of pytest+xdist bug. Pass REPO and BRANCH env vars as build-args to podman build.

Merged 2 years ago by wombelix. Opened 2 years ago by wombelix.

wombelix/pagure tests_pass_repo_and_branch_env_var_as_podman_build_args into master

tests(CI): Disable F39 RPM because of pytest+xdist bug. Pass REPO and BRANCH env vars as build-args to podman build.

Dominik Wombacher • 2 years ago

eecf5bd

run_ci_tests_containers.sh

file modified

+18 -13

		`@@ -21,23 +21,28 @@`
		`git --no-pager log -2`
		`fi`

		`- podman build --rm -t pagure-fedora-rpms-py3 \`
		`- -f dev/containers/fedora-rpms-py3 \`
		`- dev/containers`
		`-`
		- if [ ! -d `pwd`/results_fedora-rpms-py3 ]; then
		- mkdir `pwd`/results_fedora-rpms-py3;
		`- fi`
		`-`
		`- podman run --rm -it --name pagure-fedora-rpms-py3 \`
		- -v `pwd`/results_fedora-rpms-py3:/pagure/results:z \
		`- -e BRANCH=$BRANCH \`
		`- -e REPO=$REPO \`
		`- pagure-fedora-rpms-py3`
		`+ # F39 RPM SKIPPED - Bug with pytest+xdist, tests stuck and trigger OOM Killer - see https://pagure.io/pagure/pull-request/5463`
		`+ #podman build --rm -t pagure-fedora-rpms-py3 \`
		`+ # -f dev/containers/fedora-rpms-py3 \`
		`+ # --build-arg BRANCH=$BRANCH \`
		`+ # --build-arg REPO=$REPO \`
		`+ # dev/containers`
		`+ #`
		+ #if [ ! -d `pwd`/results_fedora-rpms-py3 ]; then
		+ # mkdir `pwd`/results_fedora-rpms-py3;
		`+ #fi`
		`+ #`
		`+ #podman run --rm -it --name pagure-fedora-rpms-py3 \`
		+ # -v `pwd`/results_fedora-rpms-py3:/pagure/results:z \
		`+ # -e BRANCH=$BRANCH \`
		`+ # -e REPO=$REPO \`
		`+ # pagure-fedora-rpms-py3`


		`podman build --rm -t pagure-fedora-pip-py3 \`
		`-f dev/containers/fedora-pip-py3 \`
		`+ --build-arg BRANCH=$BRANCH \`
		`+ --build-arg REPO=$REPO \`
		`dev/containers`

		if [ ! -d `pwd`/results_fedora-pip-py3 ]; then

wombelix commented 2 years ago

To proceed with https://pagure.io/pagure/pull-request/5463 I need to disable F39 RPM test runs and pass the REPO and BRANCH env var to podman build. Without the env vars, pagure.io/pagure.git:master will always be used. Changes to files like dev/containers/tox_py3.sh, dev/containers/runtests_py3.sh or files/pagure.spec are never taken into account during a PR CI run.

F39 pip isn't affected, but on rpm the tests stuck
till the OOM Killer triggers. There are multiple
similar reports upstream but no fix. To unblock
the unit tests, F39 RPM will be skipped for now.
F39 pip covers py39, py310, py311 and py312.

CI jobs that run into the issue:
https://jenkins-pagure.apps.ocp.cloud.ci.centos.org/job/pull-requests/276/
https://jenkins-pagure.apps.ocp.cloud.ci.centos.org/job/pull-requests/277/

GitHub issues that report similar issues:
https://github.com/pytest-dev/pytest-xdist/issues/110
https://github.com/pytest-dev/pytest-xdist/issues/661
https://github.com/pytest-dev/pytest-xdist/issues/872
https://github.com/pytest-dev/pytest-xdist/issues/1005

Metadata

Assignee

wombelix

Tags

No Tags

Changes Summary 1

+18 -13

file changed

run_ci_tests_containers.sh

pagure

Source Code

Documentation

#5464 tests(CI): Disable F39 RPM because of pytest+xdist bug. Pass REPO and BRANCH env vars as build-args to podman build. Merged 2 years ago by wombelix. Opened 2 years ago by wombelix. wombelix/pagure tests_pass_repo_and_branch_env_var_as_podman_build_args into master

Metadata

Changes Summary 1

#5464 tests(CI): Disable F39 RPM because of pytest+xdist bug. Pass REPO and BRANCH env vars as build-args to podman build.

Merged 2 years ago by wombelix. Opened 2 years ago by wombelix.

wombelix/pagure tests_pass_repo_and_branch_env_var_as_podman_build_args into master