PR#5274: Switch fedora containers to F34 - pagure

pagure

#5274 Switch fedora containers to F34

Merged 2 years ago by ngompa. Opened 2 years ago by zlopez.

zlopez/pagure tests into master

Switch fedora containers to F34

Michal Konečný • 2 years ago

3bb7073

dev/containers/fedora-pip-py3

file modified

+1 -1

		`@@ -1,4 +1,4 @@`
		`- FROM quay.io/fedora/fedora:35-x86_64`
		`+ FROM quay.io/fedora/fedora:34-x86_64`

		`ARG repo=https://pagure.io/pagure.git`
		`ARG branch=master`

dev/containers/fedora-rpms-py3

file modified

+1 -1

		`@@ -1,4 +1,4 @@`
		`- FROM quay.io/fedora/fedora:35-x86_64`
		`+ FROM quay.io/fedora/fedora:34-x86_64`

		`ARG repo=https://pagure.io/pagure.git`
		`ARG branch=master`

tests/test_pagure_flask_api_user.py

file modified

+1 -1

		`@@ -378,7 +378,7 @@`
		`"error": "Could not match input '2016asd' to any of the following formats: "`
		`"YYYY-MM-DD, YYYY-M-DD, YYYY-M-D, YYYY/MM/DD, YYYY/M/DD, YYYY/M/D, "`
		`"YYYY.MM.DD, YYYY.M.DD, YYYY.M.D, YYYYMMDD, YYYY-DDDD, YYYYDDDD, "`
		`- "YYYY-MM, YYYY/MM, YYYY.MM, YYYY, W.",`
		`+ "YYYY-MM, YYYY/MM, YYYY.MM, YYYY, W",`
		`"error_code": "ENOCODE",`
		`}`
		`self.assertEqual(json.loads(output.get_data(as_text=True)), exp)`

zlopez commented 2 years ago

When running CI containers with F35 they fail in CentOS CI on the following
error https://bugzilla.redhat.com/show_bug.cgi?id=2032085

This error is not happening on F34, let's switch to it then.

With this PR all tests for Fedora RPMS container are passing.

ngompa commented 2 years ago

:thumbsup:

Pull-Request has been merged by ngompa

2 years ago

zlopez commented 2 years ago

Hm, it looks like the F34 RPMs tests are failing in CI, but the container run without any failure on my local machine :-/

But at least the container is now running in CI.

ngompa commented 2 years ago

The design of the CI system means it doesn't take effect until post-merge.

zlopez commented 2 years ago

I thought that running it as this:
./dev/run-tests-container.py --fedora --repo https://pagure.io/forks/zlopez/pagure.git --branch tests will run it on my pushed changes, at least it looked like it's doing this.

ngompa commented 2 years ago

Hmm, so it does. Nevermind then :sweat_smile:

zlopez commented 2 years ago

It looks like all the issues are related to permissions to /tmp

zlopez commented 2 years ago

Here is the example error from CI:

_pygit2.GitError: failed to resolve path '/tmp/pagure-tests-path-zi7lrkl0/repos/test.git/.git/': Operation not permitted

zlopez commented 2 years ago

And I thought that it will continue running tests in other containers, but it seems it stops when the first one fails :-/

zlopez commented 2 years ago

From what I know the Pagure is one of the few projects still running on old CentOS CI and should be migrated to new one. I will try to look what needs to be done.

ngompa commented 2 years ago

That would be great! And I would appreciate it if you could teach me about the new setup once you've done that. :)