pagure

Clone

#5180 Fix tests after expanded hash len in 0f7788b
Merged 2 years ago by ngompa. Opened 2 years ago by abitrolly.
abitrolly/pagure tests-from-any  into  master

file modified
+9 -9 
@@ -291,7 +291,7 @@ 
 

          #'  PR from the feature branch\n</h3>',
 

          # output_text)
 

          self.assertIn(
 

-             'title="View file as of 2a552b">sources</a>', output_text
 

+             'title="View file as of 2a552bb">sources</a>', output_text
 

          )
 

  

          # Test if the `open changed file icon` is displayed.
 
@@ -359,7 +359,7 @@ 
 

              output_text,
 

          )
 

          self.assertIn(
 

-             'title="View file as of 2a552b">sources</a>', output_text
 

+             'title="View file as of 2a552bb">sources</a>', output_text
 

          )
 

          # Un-authenticated user cannot see this checkbox
 

          self.assertNotIn(
 
@@ -399,7 +399,7 @@ 
 

                  output_text,
 

              )
 

              self.assertIn(
 

-                 'title="View file as of 2a552b">sources</a>', output_text
 

+                 'title="View file as of 2a552bb">sources</a>', output_text
 

              )
 

              self.assertIn(
 

                  '<input id="delete_branch" name="delete_branch" type="checkbox" '
 
@@ -443,7 +443,7 @@ 
 

                  output_text,
 

              )
 

              self.assertIn(
 

-                 'title="View file as of 2a552b">sources</a>', output_text
 

+                 'title="View file as of 2a552bb">sources</a>', output_text
 

              )
 

              self.assertIn(
 

                  '<input id="delete_branch" name="delete_branch" type="checkbox" '
 
@@ -487,7 +487,7 @@ 
 

                  output_text,
 

              )
 

              self.assertIn(
 

-                 'title="View file as of 2a552b">sources</a>', output_text
 

+                 'title="View file as of 2a552bb">sources</a>', output_text
 

              )
 

              self.assertNotIn(
 

                  '<input id="delete_branch" name="delete_branch" type="checkbox" '
 
@@ -528,7 +528,7 @@ 
 

              output_text,
 

          )
 

          self.assertIn(
 

-             'title="View file as of 2a552b">sources</a>', output_text
 

+             'title="View file as of 2a552bb">sources</a>', output_text
 

          )
 

  

          # Add a new commit on the repo from
 
@@ -791,7 +791,7 @@ 
 

              #'  PR from the feature branch\n</h3>',
 

              # output_text)
 

              self.assertIn(
 

-                 'title="View file as of 2a552b">sources</a>', output_text
 

+                 'title="View file as of 2a552bb">sources</a>', output_text
 

              )
 

  

              # Wrong project
 
@@ -1254,7 +1254,7 @@ 
 

          output_text = output.get_data(as_text=True)
 

          self.assertIsNotNone(re.search(MERGED_PATTERN, output_text))
 

          self.assertIn(
 

-             'title="View file as of 2a552b">sources</a>', output_text
 

+             'title="View file as of 2a552bb">sources</a>', output_text
 

          )
 

  

      @patch("pagure.lib.notify.send_email")
 
@@ -7129,7 +7129,7 @@ 
 

                  output_text,
 

              )
 

              self.assertIn(
 

-                 'title="View file as of 2a552b">sources</a>', output_text
 

+                 'title="View file as of 2a552bb">sources</a>', output_text
 

              )
 

  

              # Wrong project

file modified
+2 -2 
@@ -83,7 +83,7 @@ 
 

          )
 

  

          self.assertTrue(
 

-             'title="View file as of %s"' % commit.oid.hex[0:6]
 

+             'title="View file as of %s"' % commit.oid.hex[0:7]
 

              in output.get_data(as_text=True)
 

          )
 

  
@@ -168,7 +168,7 @@ 
 

          )
 

  

          self.assertTrue(
 

-             'title="View file as of %s"' % commit.oid.hex[0:6]
 

+             'title="View file as of %s"' % commit.oid.hex[0:7]
 

              in output.get_data(as_text=True)
 

          )

file modified
+2 -2 
@@ -2827,7 +2827,7 @@ 
 

              )
 

              self.assertIn('<a class="pointer">1 more commits...', output_text)
 

              self.assertIn(
 

-                 'title="View file as of 4829cf">Šource</a>', output_text
 

+                 'title="View file as of 4829cfa">Šource</a>', output_text
 

              )
 

              self.assertIn(
 

                  '<div class="btn btn-outline-success disabled opacity-100 border-0 font-weight-bold">\n'
 
@@ -2859,7 +2859,7 @@ 
 

              )
 

              self.assertIn('<a class="pointer">1 more commits...', output_text)
 

              self.assertIn(
 

-                 'title="View file as of 000000">Šource</a>', output_text
 

+                 'title="View file as of 0000000">Šource</a>', output_text
 

              )
 

              self.assertIn(
 

                  '<div class="btn btn-outline-danger disabled opacity-100 border-0 font-weight-bold">\n'

0f7788b didn't include test changes, so they broke.

This PR fixes all tests in the first part of test suite. To make Jenkins pass, more fixes are needed for the last part. Probably in a separate PR.

My local run.

15 failed, 1686 passed, 9 skipped in 2582.67 seconds

Jenkins run.

15 failed, 1685 passed, 7 skipped, 441 warnings in 1964.80

Strange that 3 tests are missing in Jenkins.

Edited 2 years ago by abitrolly

1 new commit added

  • Fix some tests after expanded hash len in 0f7788b
2 years ago

Fixed some tests.

2 failed, 1698 passed, 7 skipped, 442 warnings in 1942.54 seconds

2 new commits added

  • Another tests fix for hash len change in 0f7788b
  • Use unbuffered output and show that tests are repeated
2 years ago

rebased onto f1d038d80a3d8aa59f7c5f4fad940d954e65c635
2 years ago

rebased onto 82a6f0f
2 years ago

Squashed tests fixes into a single commit.
Edited 2 years ago by abitrolly

3 new commits added

  • Fix tests after expanded hash len in 0f7788b
  • Use unbuffered output and show that tests are repeated
  • Run tests in container from any dir
2 years ago

Fixed one more test. The should make CI green again.

3 new commits added

  • Fix tests after expanded hash len in 0f7788b
  • Use unbuffered output and show that tests are repeated
  • Run tests in container from any dir
2 years ago

One more.

rebased onto 9f53f309938e8760d07c5236145866f6cf50f53d
2 years ago

Ready for review.

The change looks fine to me though Jenkins doesn't look happy :(

@pingou from what I can tell, there are two groups of tests. This fixes the first group, and you could see it if the logs didn't go away - https://ci.centos.org/job/pagure-pr/4111/console

I asked how to increase log limit here, but so far no replies https://pagure.io/centos-infra/issue/360

I am now restating the build and will attach the log here.

pretty please pagure-ci rebuild
2 years ago

rebased onto 046319f
2 years ago

This is the block fixed by this PR.

15:27:44  ============================= test session starts ==============================
15:27:44  platform linux -- Python 3.8.10, pytest-4.6.11, py-1.10.0, pluggy-0.13.1
15:27:44  rootdir: /pagure
15:27:44  plugins: celery-4.3.0, forked-1.1.1, xdist-1.31.0
15:28:03  
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 ok / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 ok / gw7 ok
collecting 0 items / 1 skipped                                                 
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 [1706] / gw6 ok / gw7 ok
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 [1706] / gw6 [1706] / gw7 ok
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 [1706] / gw6 [1706] / gw7 [1706]
gw0 [1706] / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 [1706] / gw6 [1706] / gw7 [1706]
gw0 [1706] / gw1 [1706] / gw2 ok / gw3 ok / gw4 ok / gw5 [1706] / gw6 [1706] / gw7 [1706]
gw0 [1706] / gw1 [1706] / gw2 ok / gw3 [1706] / gw4 ok / gw5 [1706] / gw6 [1706] / gw7 [1706]
gw0 [1706] / gw1 [1706] / gw2 ok / gw3 [1706] / gw4 [1706] / gw5 [1706] / gw6 [1706] / gw7 [1706]
gw0 [1706] / gw1 [1706] / gw2 [1706] / gw3 [1706] / gw4 [1706] / gw5 [1706] / gw6 [1706] / gw7 [1706]
15:28:49  ........................................................................ [  4%]
15:29:46  ........................................................................ [  8%]
15:30:59  ........................................................................ [ 12%]
15:32:12  ........................................................................ [ 16%]
15:33:21  ........................................................................ [ 21%]
15:34:28  ........................................................................ [ 25%]
15:35:36  ........................................................................ [ 29%]
15:36:46  ........................................................................ [ 33%]
15:38:09  ........................................................................ [ 37%]
15:39:32  ........................................................................ [ 42%]
15:40:52  ........................................................................ [ 46%]
15:42:42  ........................................................................ [ 50%]
15:44:47  ........................................................................ [ 54%]
15:46:50  ........................................................................ [ 59%]
15:48:33  ........................................................................ [ 63%]
15:50:01  ........................s............................................... [ 67%]
15:51:29  ........................................................................ [ 71%]
15:52:56  ........................................................................ [ 75%]
15:54:08  ........................................................................ [ 80%]
15:55:15  ........................................................................ [ 84%]
15:56:14  ........................................................................ [ 88%]
15:57:24  ........................................................................ [ 92%]
15:58:46  ........................................................................ [ 97%]
16:00:03  ...................s.s.........s...s.....s........                       [100%]
16:00:03  =============================== warnings summary ===============================

Test that are not fixed are located at the other block.

16:05:47  ============================= test session starts ==============================
16:05:47  platform linux2 -- Python 2.7.5 -- py-1.4.32 -- pytest-2.7.0
16:05:47  rootdir: /pagure, inifile: 
16:05:47  plugins: xdist, xdist, xdist, celery
16:06:04  
gw0 I / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 I / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 I / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 I / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 I / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 I / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 I / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 I
gw0 C / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 C / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 C / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 C / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 C / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 C / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 C / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 ok / gw7 C
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 ok / gw7 ok
gw0 ok / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 [1710] / gw7 ok
gw0 [1710] / gw1 ok / gw2 ok / gw3 ok / gw4 ok / gw5 ok / gw6 [1710] / gw7 ok
gw0 [1710] / gw1 ok / gw2 [1710] / gw3 ok / gw4 ok / gw5 ok / gw6 [1710] / gw7 ok
gw0 [1710] / gw1 ok / gw2 [1710] / gw3 ok / gw4 [1710] / gw5 ok / gw6 [1710] / gw7 ok
gw0 [1710] / gw1 ok / gw2 [1710] / gw3 ok / gw4 [1710] / gw5 ok / gw6 [1710] / gw7 [1710]
gw0 [1710] / gw1 [1710] / gw2 [1710] / gw3 ok / gw4 [1710] / gw5 ok / gw6 [1710] / gw7 [1710]
gw0 [1710] / gw1 [1710] / gw2 [1710] / gw3 [1710] / gw4 [1710] / gw5 ok / gw6 [1710] / gw7 [1710]
gw0 [1710] / gw1 [1710] / gw2 [1710] / gw3 [1710] / gw4 [1710] / gw5 [1710] / gw6 [1710] / gw7 [1710]
16:06:04  scheduling tests via LoadScheduling
16:34:29  ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................F......F.F........F......F...F...F.............F..F..........F...F..F....F...F...F.....F....F............F...........F.............F.........s......F......F....F......F....................................................................................................................................................................................................................................................................................................................................................................s..........................................................................................................................................................................................................................s.......s..s..s.............s.ss...
16:34:29  =================================== FAILURES ===================================

I don't know what is the difference with those LoadScheduling tests.

It appears I can not attach files here, so these results are from https://ci.centos.org/job/pagure-pr/4114/consoleFull while it is still there.

Pull-Request has been merged by ngompa
2 years ago

I give up, this is merged now.
Metadata
None
No Tags
Changes Summary 3
+9 -9
file changed
tests/test_pagure_flask_ui_fork.py
+2 -2
file changed
tests/test_pagure_flask_ui_old_commit.py
+2 -2
file changed
tests/test_pagure_flask_ui_repo.py
Powered by Pagure 5.13.3
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.