PR#5144: Set git hashes length to 7 - pagure

pagure

#5144 Set git hashes length to 7

Merged 3 years ago by ngompa. Opened 3 years ago by josseline.

josseline/pagure short-length-config into master

Set git hashes length to 7

Josseline Perdomo • 3 years ago

0f7788b

dev/ansible/roles/pagure-dev/files/pagure.cfg

file modified

+1 -1

		`@@ -85,7 +85,7 @@`
		`MAX_CONTENT_LENGTH = 4 * 1024 * 1024 # 4 megabytes`

		`### Lenght for short commits ids or file hex`
		`- SHORT_LENGTH = 6`
		`+ SHORT_LENGTH = 7`

		`### IP addresses allowed to access the internal endpoints`
		`### These endpoints are used by the milter and are security sensitive, thus`

files/pagure.cfg.sample

file modified

+1 -1

		`@@ -142,7 +142,7 @@`
		`MAX_CONTENT_LENGTH = 4 * 1024 * 1024 # 4 megabytes`

		`### Lenght for short commits ids or file hex`
		`- SHORT_LENGTH = 6`
		`+ SHORT_LENGTH = 7`

		`### List of blacklisted project names that can conflicts for pagure's URLs`
		`### or other`

pagure/default_config.py

file modified

+1 -1

		`@@ -283,7 +283,7 @@`
		`CHECK_SESSION_IP = True`

		`# Lenght for short commits ids or file hex`
		`- SHORT_LENGTH = 6`
		`+ SHORT_LENGTH = 7`

		`# Used by SESSION_COOKIE_PATH`
		`APPLICATION_ROOT = "/"`

josseline commented 3 years ago

Resolves: #5067

Update SHORT_LENGTH to 7

pingou commented 3 years ago

:thumbsup:

This is technically not backward compatible (though I don't think people rely really on this).

josseline commented 3 years ago

Thanks for your reply @pingou, this is my first approach to Pagure :)

Why this approach is not backward compatible? When I did it I noticed this change would affect only how the commit hash is presented in the template. Does it affect any stored data?

ngompa commented 3 years ago

It makes it so that URL slugs referencing commits with 6 characters doesn't work anymore, but I think that doesn't actually happen much in practice.

pingou commented 3 years ago

Why this approach is not backward compatible? When I did it I noticed this change would affect only how the commit hash is presented in the template. Does it affect any stored data?

Your approach is correct, the very nature of changing the default configuration
is not backward compatible. It is fine, just something to be aware of :)
(especially regarding the version of pagure that has this code change)

josseline commented 3 years ago

Hi @pingou, sorry but I did not understand if I have to change something :sweat_smile: