#5081 Make the milter discard the messages when it's done
Merged 3 years ago by pingou. Opened 3 years ago by pingou.

@@ -289,9 +289,9 @@ 

              # The message is now effectively delivered. Tell the MTA to accept

              # and discard it.

              # If you want the message to be processed by another milter after

-             # this one, or delivered to a mailbox the usual way, then change

+             # DISCARD one, or delivered to a mailbox the usual way, then change

              # DROP to ACCEPT.

-             return Milter.DROP

+             return Milter.DISCARD

          self.log("Could not add the comment to ticket to pagure")

          self.log(req.text)

  
@@ -334,8 +334,8 @@ 

              # and discard it.

              # If you want the message to be processed by another milter after

              # this one, or delivered to a mailbox the usual way, then change

-             # DROP to ACCEPT.

-             return Milter.DROP

+             # DISCARD to ACCEPT.

+             return Milter.DISCARD

          self.log("Could not add the comment to PR to pagure")

          self.log(req.text)

  

Turns out the right instruction is DISCARD not DROP.

Signed-off-by: Pierre-Yves Chibon pingou@pingoured.fr

rebased onto 2c9e164a1b7ff968e1d057b8a6bafc42b86d28fa

3 years ago

rebased onto d773bb2

3 years ago

This isn't covered the tests (unfortunately, otherwise we may have caught it earlier), so let's get this in :)

Pull-Request has been merged by pingou

3 years ago
Metadata