#5027 Change the PR flag API endpoints to use commit flags
Merged by pingou. Opened by pingou.
commit_flags  into  master

Download 5027.patch
no initial comment

pretty please pagure-ci rebuild

3 new commits added

  • Rework how PR flags are show in the UI
  • Change the PR flag API endpoints to use commit flags
  • When returning the commits flags in the API, returned them by update date

3 new commits added

  • Rework how PR flags are show in the UI
  • Change the PR flag API endpoints to use commit flags
  • When returning the commits flags in the API, returned them by update date

3 new commits added

  • Rework how PR flags are show in the UI
  • Change the PR flag API endpoints to use commit flags
  • When returning the commits flags in the API, returned them by update date

To give an idea of what it looks like:

pagure_new_pr_flag.png

:thumbsup:

rebased onto 83845808fe15b193e7f34a1e92f1150642317119

:thumbsup:

@pingou Does it make sense to have the flags column on the right side if they're all in the PR body now?

@pingou Does it make sense to have the flags column on the right side if they're all in the PR body now?

For now yes, as otherwise existing flags will not show at all

Okay, then this is good to merge.

1 new commit added

  • Document the risk of race-condition in the PR flag API endpoint

rebased onto 56c3184debf62fba0b23b083d8fa4c3ae2df1382

I'm sure there will be things to adjust (I know the PR list will need to be adjusted for example), but let's start with this and see how we do :)

Pull-Request has been merged by pingou

Metadata