PR#4893: Miscellaneous fixes - pagure

pagure

#4893 Miscellaneous fixes

Merged 3 years ago by pingou. Opened 3 years ago by pingou.

fixes into master

Fix the title of the graph showing the evolution of the number of open tickets on a project

Pierre-Yves Chibon • 3 years ago

907ba17

Ensure the title/name of the headers are strings

Pierre-Yves Chibon • 3 years ago

8f8e201

Do not assume there is a SMTP_STARTTLS configuration key set

Pierre-Yves Chibon • 3 years ago

a5a0e79

pagure/lib/notify.py

file modified

+1 -1

		`@@ -506,7 +506,7 @@`
		`pagure_config["SMTP_PORT"],`
		`)`

		`- if pagure_config["SMTP_STARTTLS"]:`
		`+ if pagure_config.get("SMTP_STARTTLS"):`
		`context = ssl.create_default_context()`
		`keyfile = pagure_config.get("SMTP_KEYFILE") or None`
		`certfile = pagure_config.get("SMTP_CERTFILE") or None`

pagure/static/issues_stats.js

file modified

+1 -1

		`@@ -70,7 +70,7 @@`
		`},`
		`title: {`
		`display: true,`
		`- text: 'Evolution of the number of commits over the last year'`
		`+ text: 'Evolution of the number of open tickets over the last year'`
		`}`
		`}`
		`});`

pagure/ui/clone.py

file modified

+1 -1

		`@@ -205,7 +205,7 @@`
		`break`
		`header = line.split(b": ", 1)`
		`header[0] = header[0].decode("utf-8")`
		`- headers[header[0].lower()] = header[1]`
		`+ headers[str(header[0].lower())] = header[1]`

		`if len(headers) == 0:`
		`raise Exception("No response at all received")`

pingou commented 3 years ago

A few small fixes that made 5.10.0 annoying at times

ngompa commented 3 years ago

I think 665ff745d99b5f1557cb0203ea575c0b43963c89 in this PR looks a lot more like a feature than miscellaneous fixes...

pingou commented 3 years ago

lol :)

rebased onto a5a0e79

3 years ago

ngompa commented 3 years ago

:thumbsup:

pingou commented 3 years ago

Looks like celery missed adding in a new dependency so the pip-based environment is not passing but the first two are, so I'm going to merge this PR :)