#4780 Update README to make commands in Docker Compose clearer
Merged 4 months ago by pingou. Opened 4 months ago by deveshks.

file modified
+2 -2

@@ -48,7 +48,7 @@ 

  For more information about docker-compose cli, see: https://docs.docker.com/compose/reference/.

  

  Once installed, create the folder that will receive the projects, forks, docs,

- requests and tickets' git repo. Run this command exactly as it appears::

+ requests and tickets' git repo. Run this command exactly as it appears from within the cloned git repo folder::

  

      $ mkdir -p lcl/{repos,remotes,attachments,releases}

  

@@ -64,7 +64,7 @@ 

  Once all the containers have started, you can access pagure on http://localhost:5000.

  To stop the containers, press Ctrl+C.

  

- To populate the container with test data and create a new account, run ::

+ Once the containers are up and running after running the previous command, run this command to populate the container with test data and create a new account ::

We tend to wrap lines at around 80 characters, including in the README.

  

      $ docker-compose -f dev/docker-compose.yml exec web python dev-data.py --all

  

in order to populate the container with test data and create a new account, run -> run this command to populate the container with test data and create a new account

in order to populate the container with test data and create a new account, run -> run this command to populate the container with test data and create a new account

This wording is more clearer than mine. Thanks, I will make the change

1 new commit added

  • Fixed wording for docker command which creates new users
4 months ago

@deveshks Could you please squash into one commit?

You can do so by doing the following:

$ git rebase -i HEAD~2
<change the new commit to 'fixup' from 'pick' and save+quit>
$ git push -f

rebased onto cb116e3

4 months ago

Hi @ngompa ,

I have squashed the two commits in one.

Hi @ngompa,

Can I now merge it myself, or perhaps you can merge it if it looks good.

We tend to wrap lines at around 80 characters, including in the README.

I'll merge this PR manually so that I can do the wrapping before pushing and you won't have to bother with it :)

Thanks for the patch!

Commit 4e6f387 fixes this pull-request

Pull-Request has been merged by pingou

4 months ago

Hi @pingou,

Thanks for the comment and the suggestions. I will keep it in mind in future PRs