PR#4771: Use the package_unretirement template with releng unretirement - pagure

pagure

#4771 Use the package_unretirement template with releng unretirement

Merged 4 years ago by pingou. Opened 4 years ago by churchyard.

churchyard/pagure unretire_template into master

Make sure orphaned & retired packages can be claimed

Miro Hrončok • 4 years ago

0491a61

Use the package_unretirement template with releng unretirement

Miro Hrončok • 4 years ago

5f7fc38

pagure/themes/srcfpo/templates/repo_master_sidebar.html

file modified

+3 -3

		`@@ -350,13 +350,13 @@`
		`_btn.click(function(){`
		`window.open(`
		`"https://pagure.io/releng/new_issue?title="`
		`- + "Unretire {{repo.namespace}}/{{repo.name}}");`
		`+ + "Unretire {{repo.namespace}}/{{repo.name}}"`
		`+ + "&template=package_unretiremet");`
		`});`
		`_btn.prop( "title", "Package retired - Open a releng ticket to adopt it" );`
		`_btn.html("Retired");`
		`- } else {`
		`- _btn.removeClass('disabled');`
		`}`
		`+ _btn.removeClass('disabled');`
		`}`
		`});`
		`{% endif %}`

churchyard commented 4 years ago

I'm trying to run the tests with tox, but so far I'm getting some gcc errors :(

rebased onto 5f7fc38

4 years ago

churchyard commented 4 years ago

I'm trying to run the tests with tox, but so far I'm getting some gcc errors :(

I give up. If this template is tested, please let me know where and I'll adapt the test blindly.

pingou commented 4 years ago

The src.fp.o theme isn't tested, but I'll test it locally quickly :)

churchyard commented 4 years ago

Thanks.

pingou commented 4 years ago

To get it to work I also had to add:

             _btn.prop( "title", "Package retired - Open a releng ticket to adopt it" );
             _btn.html("Retired");
+            _btn.removeClass('disabled');

Could you add it to your PR?

pingou commented 4 years ago

Or simpler:

             });
             _btn.prop( "title", "Package retired - Open a releng ticket to adopt it" );
             _btn.html("Retired");
-          } else {
-            _btn.removeClass('disabled');
           }
+          _btn.removeClass('disabled');
         }
       });

churchyard commented 4 years ago

I can but I don't understand why. I only want to change the link.

pingou commented 4 years ago

The button remains disabled for me when I test this locally, meaning clicking on it doesn't send to the releng project. I can put this in a different PR if you prefer

churchyard commented 4 years ago

Like that?

1 new commit added

Move "disabled" code around as @pingou told me to

4 years ago

pingou commented 4 years ago

The code and change looks good, the commit message a little less :(

churchyard commented 4 years ago

I can put a real rationale in there, but I really have no idea what it is.

If you tell me the commit message, I'll amend.

pingou commented 4 years ago

How does this reads?

When the package is orphaned, the "take" button shows as disabled in the UI, until we check if the package is orphaned and retired or just orphaned. Except that in the case where the package is orphaned and retired, we re-purpose that button to send the users to the releng issue tracker to ask for the package to be un-retired/un-blocked, but we did not re-enable the button. This led to a button being re-purposed but not re-actived, and thus clicking on the button did not have any effect.
This commit fixes that by making sure that we always re-enable the button, either because the package is orphaned and not retired and packagers can just adopt it, or because the package is orphaned and retired and by clicking on the button packagers will be sent to the releng issue tracker where they'll be able to ask for the package to be un-blocked.

2 new commits added