PR#4766: api/issue: allow viewing issues with user tokens -

pagure

#4766 api/issue: allow viewing issues with user tokens

Merged Mar 30, 2020 by pingou. Opened Mar 6, 2020 by jlanda.

jlanda/pagure api-issue-user-tokens into master

Download 4766.patch

jlanda commented Mar 6, 2020

Fixes #4764

cverna commented Mar 6, 2020

LGTM

pingou commented Mar 6, 2020

Should we add unit-tests?

jlanda commented Mar 6, 2020

Should we add unit-tests?

Good point. I'll add one with a non committer user token

rebased onto 05047c0af3a2d67e5bf89d0de4a676886d8a6f71

Mar 29, 2020

jlanda commented Mar 29, 2020

Should we add unit-tests?

Actually I edited the wrong _check_token() call on the first attempt :D

Fixed and test added :)

rebased onto ed1aa4d0419f885bc0e0ec4c93b51403dfb9545f

Mar 29, 2020

pretty please pagure-ci rebuild

Mar 29, 2020

ngompa commented Mar 30, 2020

@jlanda You may want to rebase again, and the CI is stuck...

jlanda commented Mar 30, 2020

yeah, second time on this pr that ci stucks :(

rebased onto 44e0edbf2af36c1969be257dd1f1d697a6dab184

Mar 30, 2020

jlanda commented Mar 30, 2020

Now that is rebased and ci went ok, this is ready for review =)

rebased onto 069347c63424d01799eb01e35f5f7dc8d3f30420

Mar 30, 2020

pretty please pagure-ci rebuild

Mar 30, 2020

ngompa commented Mar 30, 2020

:thumbsup:

pingou commented Mar 30, 2020

Thanks :)

Pull-Request has been merged by pingou

Mar 30, 2020

Metadata

Assignee

None

Tags

No Tags

pagure

#4766 api/issue: allow viewing issues with user tokens Merged Mar 30, 2020 by pingou. Opened Mar 6, 2020 by jlanda. jlanda/pagure api-issue-user-tokens into master

Metadata

#4766 api/issue: allow viewing issues with user tokens

Merged Mar 30, 2020 by pingou. Opened Mar 6, 2020 by jlanda.

jlanda/pagure api-issue-user-tokens into master