#4665 swap "Add" and "Cancel" button ordering for access management
Merged 4 years ago by pingou. Opened 4 years ago by ktdreyer.
ktdreyer/pagure add-user-buttons  into  master

@@ -36,8 +36,8 @@ 

        </fieldset>

  

        <p class="buttons indent">

-         <input type="button" value="Cancel" class="btn btn-secondary cancel_btn">

          <input type="submit" class="btn btn-primary" id="add_update_button" value="Add">

+         <input type="button" value="Cancel" class="btn btn-secondary cancel_btn">

          {{ form.csrf_token }}

        </p>

      </form>

@@ -34,8 +34,8 @@ 

        </fieldset>

  

        <p class="buttons indent">

-         <input type="button" value="Cancel" class="btn btn-secondary cancel_btn">

          <input type="submit" class="btn btn-primary" id="add_update_button" value="Add">

+         <input type="button" value="Cancel" class="btn btn-secondary cancel_btn">

          {{ form.csrf_token }}

        </p>

      </form>

Prior to this change, the "Cancel" button was much too close to the place where users click to select an access level. This made it too easy
for users to accidentally click the "Cancel" button after quickly clicking on all the other interface choices.

Move the "Add" button to the left so that it is directly below the dropdown input field.

pretty please pagure-ci rebuild

4 years ago

pretty please pagure-ci rebuild

4 years ago

@ktdreyer could you edit the PR and click on the checkbox allowing us to rebase your PR please? :)

Thanks!

pretty please pagure-ci rebuild

4 years ago

Ok, the tests are passing locally, so I'll go ahead and merge this manually, but since this changes the UI, I'll make a 5.8.1 release before.

Commit c44f49e fixes this pull-request

Pull-Request has been merged by pingou

4 years ago