#4580 Improve release-monitoring button functionality and feedback
Merged 4 years ago by pingou. Opened 4 years ago by jlanda.

@@ -124,8 +124,7 @@ 

  

                  <div class="btn-group">

                    {% if g.authenticated and not g.repo_starred %}

-                     <a href="#" class="btn btn-sm btn-outline-primary font-weight-bold"

-                     onclick="$('#star_project').submit();">

+                     <a href="#" class="btn btn-sm btn-outline-primary font-weight-bold star_btn">

                        <i class="fa fa-star-o fa-fw"></i>Star

                        <form method="POST" name="star_project" id="star_project"

                        action="{{ url_for(
@@ -144,8 +143,7 @@ 

                                    namespace=repo.namespace,

                        )}}" class="btn btn-sm btn-primary font-weight-bold">{{ repo.stargazers|length }}</a>

                    {% elif g.authenticated and g.repo_starred %}

-                     <a href="#" class="btn btn-sm btn-outline-primary font-weight-bold"

-                       onclick="$('#unstar_project').submit();">

+                     <a href="#" class="btn btn-sm btn-outline-primary font-weight-bold unstar_btn">

                        <form method="POST" name="unstar_project" id="unstar_project"

                          action="{{ url_for(

                          'ui_ns.star_project',
@@ -453,6 +451,8 @@ 

  {{ super() }}

  <script type="text/javascript" nonce="{{ g.nonce }}">

  $(document).ready(function() {

+     $('.star_btn').click( function() { $('#star_project').submit()} );

+     $('.unstar_btn').click( function() { $('#unstar_project').submit()} );

      {% if g.repo_watch_levels %}

          var currentWatchStatusButton = $('#watch_{{ g.repo_watch_levels | join('_') }}_button .check-icon span');

      {% else %}

@@ -69,6 +69,7 @@ 

    <div class="col-xs-2 line-height-1"></div>

    <p>Monitoring status:</p>

    <div class="btn-group">

+     {% if g.authenticated %}

      <a href="#" title="Monitoring status"

          class="btn btn-sm dropdown-toggle btn-outline-primary"

          data-toggle="dropdown" id="monitoring-button">
@@ -102,11 +103,18 @@ 

              <span class="fa fa-fw"></span>

            </div>

            <div class="media-body">

-             monitoring and scratch builds

+             Monitoring and scratch builds

            </div>

          </div>

        </a>

      </div>

+     {% else %}

+     <button title="Monitoring status" class="btn btn-sm btn-outline-primary disabled"

+         id="monitoring-button">

+       <i id="monitoring-icon" class="fa fa-fw fa-eye"></i>

+       <span id="monitoring-label" class="fa fa-circle-o-notch fa-spin fa-1x fa-fw"></span>

+     </button>

+     {% endif %}

    </div>

  

    {% if g.authenticated and repo.user.user == "orphan" %}
@@ -174,7 +182,7 @@ 

              set_up_monitoring(res.monitoring)

            },

            error: function() {

-             alert('Unable to change the monitoring status! ' + error);

+             alert('Unable to change the monitoring status!');

            }

          });

        });